From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 465E0C3A5A1 for ; Wed, 28 Aug 2019 08:32:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 192CF2342A for ; Wed, 28 Aug 2019 08:32:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726472AbfH1Icx (ORCPT ); Wed, 28 Aug 2019 04:32:53 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:21664 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726292AbfH1Icx (ORCPT ); Wed, 28 Aug 2019 04:32:53 -0400 X-UUID: c0b76ca13e734927a29b3ac15c57aa67-20190828 X-UUID: c0b76ca13e734927a29b3ac15c57aa67-20190828 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1611986398; Wed, 28 Aug 2019 16:32:49 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n2.mediatek.inc (172.21.101.101) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 28 Aug 2019 16:32:53 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 28 Aug 2019 16:32:53 +0800 Message-ID: <1566981166.31833.21.camel@mtksdaap41> Subject: Re: [RESEND, PATCH v13 11/12] soc: mediatek: cmdq: add cmdq_dev_get_client_reg function From: Bibby Hsieh To: Matthias Brugger CC: Jassi Brar , Rob Herring , CK HU , Daniel Kurtz , "Sascha Hauer" , , , , , , "Sascha Hauer" , Philipp Zabel , Nicolas Boichat , YT Shen , Daoyuan Huang , Jiaguang Zhang , Dennis-YC Hsieh , Houlong Wei , Date: Wed, 28 Aug 2019 16:32:46 +0800 In-Reply-To: References: <20190820084932.22282-1-bibby.hsieh@mediatek.com> <20190820084932.22282-12-bibby.hsieh@mediatek.com> <1566878368.29523.1.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-SNTS-SMTP: 3A49F78DCF6A33DAF3FCCD33C1485A7F22BDB34F6B84E8949B1A3282971FEA442000:8 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-08-27 at 12:13 +0200, Matthias Brugger wrote: > > On 27/08/2019 05:59, Bibby Hsieh wrote: > > On Fri, 2019-08-23 at 16:21 +0200, Matthias Brugger wrote: > >> > >> On 20/08/2019 10:49, Bibby Hsieh wrote: > >>> GCE cannot know the register base address, this function > >>> can help cmdq client to get the cmdq_client_reg structure. > >>> > >>> Signed-off-by: Bibby Hsieh > >>> Reviewed-by: CK Hu > >>> --- > >>> drivers/soc/mediatek/mtk-cmdq-helper.c | 29 ++++++++++++++++++++++++++ > >>> include/linux/soc/mediatek/mtk-cmdq.h | 21 +++++++++++++++++++ > >>> 2 files changed, 50 insertions(+) > >>> > >>> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > >>> index c53f8476c68d..80f75a1075b4 100644 > >>> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > >>> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > >>> @@ -27,6 +27,35 @@ struct cmdq_instruction { > >>> u8 op; > >>> }; > >>> > >>> +int cmdq_dev_get_client_reg(struct device *dev, > >>> + struct cmdq_client_reg *client_reg, int idx) > >>> +{ > >> > >> Can't we do/call this in cmdq_mbox_create parsing the number of gce-client-reg > >> properties we have and allocating these using a pointer to cmdq_client_reg in > >> cmdq_client? > >> We will have to free the pointer then in cmdq_mbox_destroy. > >> > >> Regards, > >> Matthias > > > > I don't think we need to keep the cmdq_client_reg in cmdq_client > > structure. > > Because our client will have own data structure, they will copy the > > client_reg information into their own structure. > > > > In the design now, we do not allocate the cmdq_client_reg, client pass > > the cmdq_client_reg pointer into this API. > > Client will destroy the pointer after they get the information they > > want. > > > > My point wasn't so much about the lifecycle of the object, but the fact that we > add another call, which can be already full-filled by a necessary previous call > to cmdq_mbox_create. So I would prefer to add the information gathering for > cmdq_client_reg in this call, and let it live there for the time cmdq_client > lives. In the end we are talking about 40 bits of memory. > Thanks for the comments. :D Actually, I'm working for developing the chandes for MTK DRM apply cmdq interface. For MTK DRM, all the components included in MTK_CRTC use one mailbox channel. According to [1], we create mailbox channel by mmsys device node after get all the informations (include cmdq_client_reg) about every device node of display components respectively. Please refer to [2], [3] and [4], I'm going to upstream them recently. If create mailbox channel and get the cmdq_client_reg in the same device node, your suggestion is good for me. But from display and mdp's viewpoint now, I don't think it is convenient for them. So I still prefer separate this function out of cmdq_mbox_create.:D [1] https://elixir.bootlin.com/linux/latest/source/arch/arm64/boot/dts/mediatek/mt8173.dtsi#907 [2] get cmdq_client_reg in mtk_ddp_comp_init() https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1746354/12/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c#431 [3] create mailbox channel in mtk_drm_crtc_create() https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1746354/12/drivers/gpu/drm/mediatek/mtk_drm_crtc.c#814 [4] After component_bind_all(), the mtk_drm_crtc_create will be called https://chromium.googlesource.com/chromiumos/third_party/kernel/+/e15c2dc6ceb4810a2090cd11a512932095866559/drivers/gpu/drm/mediatek/mtk_drm_drv.c#452 Thanks. Bibby > Regards, > Matthias > > > Thanks for the comments so much. > > > > Bibby > > > >> > >>> + struct of_phandle_args spec; > >>> + int err; > >>> + > >>> + if (!client_reg) > >>> + return -ENOENT; > >>> + > >>> + err = of_parse_phandle_with_fixed_args(dev->of_node, > >>> + "mediatek,gce-client-reg", > >>> + 3, idx, &spec); > >>> + if (err < 0) { > >>> + dev_err(dev, > >>> + "error %d can't parse gce-client-reg property (%d)", > >>> + err, idx); > >>> + > >>> + return err; > >>> + } > >>> + > >>> + client_reg->subsys = (u8)spec.args[0]; > >>> + client_reg->offset = (u16)spec.args[1]; > >>> + client_reg->size = (u16)spec.args[2]; > >>> + of_node_put(spec.np); > >>> + > >>> + return 0; > >>> +} > >>> +EXPORT_SYMBOL(cmdq_dev_get_client_reg); > >>> + > >>> static void cmdq_client_timeout(struct timer_list *t) > >>> { > >>> struct cmdq_client *client = from_timer(client, t, timer); > >>> diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > >>> index a345870a6d10..02ddd60b212f 100644 > >>> --- a/include/linux/soc/mediatek/mtk-cmdq.h > >>> +++ b/include/linux/soc/mediatek/mtk-cmdq.h > >>> @@ -15,6 +15,12 @@ > >>> > >>> struct cmdq_pkt; > >>> > >>> +struct cmdq_client_reg { > >>> + u8 subsys; > >>> + u16 offset; > >>> + u16 size; > >>> +}; > >>> + > >>> struct cmdq_client { > >>> spinlock_t lock; > >>> u32 pkt_cnt; > >>> @@ -24,6 +30,21 @@ struct cmdq_client { > >>> u32 timeout_ms; /* in unit of microsecond */ > >>> }; > >>> > >>> +/** > >>> + * cmdq_dev_get_client_reg() - parse cmdq client reg from the device > >>> + * node of CMDQ client > >>> + * @dev: device of CMDQ mailbox client > >>> + * @client_reg: CMDQ client reg pointer > >>> + * @idx: the index of desired reg > >>> + * > >>> + * Return: 0 for success; else the error code is returned > >>> + * > >>> + * Help CMDQ client parsing the cmdq client reg > >>> + * from the device node of CMDQ client. > >>> + */ > >>> +int cmdq_dev_get_client_reg(struct device *dev, > >>> + struct cmdq_client_reg *client_reg, int idx); > >>> + > >>> /** > >>> * cmdq_mbox_create() - create CMDQ mailbox client and channel > >>> * @dev: device of CMDQ mailbox client > >>> > > > >