From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
NFS maillist <nfs@lists.sourceforge.net>
Subject: [PATCH] Support for cached lookups via readdirplus [1/6]
Date: Sun, 28 Jul 2002 17:25:10 +0200 [thread overview]
Message-ID: <15684.3286.74735.41434@charged.uio.no> (raw)
Cleanup for the readdirplus code. Make struct nfs_entry take pointers
to the filehandle and file attributes.
Cheers,
Trond
diff -u --recursive --new-file linux-2.5.29-noac/fs/nfs/dir.c linux-2.5.29-rdplus1/fs/nfs/dir.c
--- linux-2.5.29-noac/fs/nfs/dir.c Fri Jul 26 23:15:42 2002
+++ linux-2.5.29-rdplus1/fs/nfs/dir.c Sat Jul 27 18:10:53 2002
@@ -333,7 +333,8 @@
/* Reset read descriptor so it searches the page cache from
* the start upon the next call to readdir_search_pagecache() */
desc->page_index = 0;
- memset(desc->entry, 0, sizeof(*desc->entry));
+ desc->entry->cookie = desc->entry->prev_cookie = 0;
+ desc->entry->eof = 0;
out:
dfprintk(VFS, "NFS: uncached_readdir() returns %d\n", status);
return status;
@@ -352,6 +353,8 @@
nfs_readdir_descriptor_t my_desc,
*desc = &my_desc;
struct nfs_entry my_entry;
+ struct nfs_fh fh;
+ struct nfs_fattr fattr;
long res;
lock_kernel();
@@ -369,13 +372,17 @@
* itself.
*/
memset(desc, 0, sizeof(*desc));
- memset(&my_entry, 0, sizeof(my_entry));
desc->file = filp;
desc->target = filp->f_pos;
- desc->entry = &my_entry;
desc->decode = NFS_PROTO(inode)->decode_dirent;
+ my_entry.cookie = my_entry.prev_cookie = 0;
+ my_entry.eof = 0;
+ my_entry.fh = &fh;
+ my_entry.fattr = &fattr;
+ desc->entry = &my_entry;
+
while(!desc->entry->eof) {
res = readdir_search_pagecache(desc);
if (res == -EBADCOOKIE) {
diff -u --recursive --new-file linux-2.5.29-noac/fs/nfs/nfs3xdr.c linux-2.5.29-rdplus1/fs/nfs/nfs3xdr.c
--- linux-2.5.29-noac/fs/nfs/nfs3xdr.c Tue Jul 16 13:43:08 2002
+++ linux-2.5.29-rdplus1/fs/nfs/nfs3xdr.c Sat Jul 27 17:56:10 2002
@@ -603,21 +603,19 @@
p = xdr_decode_hyper(p, &entry->cookie);
if (plus) {
- p = xdr_decode_post_op_attr(p, &entry->fattr);
+ entry->fattr->valid = 0;
+ p = xdr_decode_post_op_attr(p, entry->fattr);
/* In fact, a post_op_fh3: */
if (*p++) {
- p = xdr_decode_fhandle(p, &entry->fh);
+ p = xdr_decode_fhandle(p, entry->fh);
/* Ugh -- server reply was truncated */
if (p == NULL) {
dprintk("NFS: FH truncated\n");
*entry = old;
return ERR_PTR(-EAGAIN);
}
- } else {
- /* If we don't get a file handle, the attrs
- * aren't worth a lot. */
- entry->fattr.valid = 0;
- }
+ } else
+ memset((u8*)(entry->fh), 0, sizeof(*entry->fh));
}
entry->eof = !p[0] && p[1];
diff -u --recursive --new-file linux-2.5.29-noac/include/linux/nfs_xdr.h linux-2.5.29-rdplus1/include/linux/nfs_xdr.h
--- linux-2.5.29-noac/include/linux/nfs_xdr.h Fri Jul 26 16:35:23 2002
+++ linux-2.5.29-rdplus1/include/linux/nfs_xdr.h Sat Jul 27 17:56:10 2002
@@ -109,8 +109,8 @@
const char * name;
unsigned int len;
int eof;
- struct nfs_fh fh;
- struct nfs_fattr fattr;
+ struct nfs_fh * fh;
+ struct nfs_fattr * fattr;
};
/*
reply other threads:[~2002-07-28 15:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15684.3286.74735.41434@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®