From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753137AbcHOX6Q (ORCPT ); Mon, 15 Aug 2016 19:58:16 -0400 Received: from sender153-mail.zoho.com ([74.201.84.153]:21265 "EHLO sender153-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752258AbcHOX6O (ORCPT ); Mon, 15 Aug 2016 19:58:14 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=date:from:to:cc:message-id:in-reply-to:references:subject:mime-version:content-type:user-agent; b=khVnBMRPe+gzCJ1dY8yBwigZUrECJ75vP0pjSvzR3AN3DFbWb4b6rdezllyrKMZfZ618hbBxE6FF RVbdPEeBZLn7hgB603Beq8JymkN1H1BZSh7/4A+KtqhhXM/9Q8V7 Date: Mon, 15 Aug 2016 16:58:11 -0700 From: perr perr To: "Krzysztof Kozlowski" Cc: "" , "" , "" , "" , "" , "" , "" , "" Message-ID: <15690a422ec.d724844125972.3079329677610732706@zoho.com> In-Reply-To: <20160815165941.GA3769@kozik-lap> References: <1471256227-6282-1-git-send-email-strongbox8@zoho.com> <20160815165941.GA3769@kozik-lap> Subject: Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Priority: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sent using Zoho Mail ---- On Mon, 15 Aug 2016 09:59:41 -0700 Krzysztof Kozlowski wrote ---- > On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote: > > Because chained_irq_enter() has already called chip->irq_mask() and > > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), > > so it's not necessary to call chip->irq_*() here. > > > > Signed-off-by: perr > > > > --- > > drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > > Looks correct so for the patch itself: > Reviewed-by: Krzysztof Kozlowski > > However, your name "Perr" confuses me a little bit. For the > Signed-off-by statement, as mentioned in > Documentation/SubmittingPatches, a real name is required. The name > should match the author. > > Would you be so kind as to use a full, real name? Unless Perr is your > full, real name... then sorry for the trouble. Perr Zhang is OK? I'm from China. Perr is my first name in English. > > Best regards, > Krzysztof > >