From: Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>
To: unlisted-recipients:; (no To-header on input)
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Mario Limonciello" <Mario.Limonciello@dell.com>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Darren Hart" <dvhart@infradead.org>,
"Andy Shevchenko" <andy@infradead.org>,
"Platform Driver" <platform-driver-x86@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] platform/x86: dell-laptop: fix broken kbd backlight on Inspiron 10xx
Date: Thu, 12 Sep 2019 00:07:45 +0200 [thread overview]
Date: Wed, 25 Sep 2019 11:48:12 +0200 [thread overview]
Message-ID: <156940489220.8635.14349142383780268583@WARFSTATION> (raw)
In-Reply-To: <20190925082149.yjhmmb64i4h6sddi@pali>
This patch adds a quirk disabling keyboard backlight support for the
Dell Inspiron 1012 and 1018.
Those models wrongly report supporting keyboard backlight control
features (through SMBIOS tokens) even though they're not equipped with
a backlit keyboard. This led to broken controls being exposed
through sysfs by this driver which froze the system when used.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=107651
Signed-off-by: Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>
---
drivers/platform/x86/dell-laptop.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index d27be2836bc2..ffe5abbdadda 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -33,6 +33,7 @@
struct quirk_entry {
bool touchpad_led;
+ bool kbd_broken_backlight;
bool kbd_led_levels_off_1;
bool kbd_missing_ac_tag;
@@ -73,6 +74,10 @@ static struct quirk_entry quirk_dell_latitude_e6410 = {
.kbd_led_levels_off_1 = true,
};
+static struct quirk_entry quirk_dell_inspiron_1012 = {
+ .kbd_broken_backlight = true,
+};
+
static struct platform_driver platform_driver = {
.driver = {
.name = "dell-laptop",
@@ -310,6 +315,24 @@ static const struct dmi_system_id dell_quirks[] __initconst = {
},
.driver_data = &quirk_dell_latitude_e6410,
},
+ {
+ .callback = dmi_matched,
+ .ident = "Dell Inspiron 1012",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 1012"),
+ },
+ .driver_data = &quirk_dell_inspiron_1012,
+ },
+ {
+ .callback = dmi_matched,
+ .ident = "Dell Inspiron 1018",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 1018"),
+ },
+ .driver_data = &quirk_dell_inspiron_1012,
+ },
{ }
};
@@ -2040,6 +2063,9 @@ static int __init kbd_led_init(struct device *dev)
{
int ret;
+ if (quirks && quirks->kbd_broken_backlight)
+ return -ENODEV;
+
kbd_init();
if (!kbd_led_present)
return -ENODEV;
--
2.19.2
next prev parent reply other threads:[~2019-09-25 9:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <156824368856.28378.14511879419677114177@WARFSTATION>
2019-09-12 7:33 ` [PATCH] platform/x86: dell-laptop: fix phantom " Pali Rohár
2019-09-12 13:30 ` Andy Shevchenko
[not found] ` <156882055514.9370.16951540573597044820@WARFSTATION>
2019-09-22 13:43 ` Pali Rohár
2019-09-23 13:24 ` Mario.Limonciello
2019-09-25 8:07 ` Andy Shevchenko
2019-09-25 8:21 ` Pali Rohár
2019-09-11 22:07 ` Pacien TRAN-GIRARD [this message]
2019-09-25 13:18 ` [PATCH v2] platform/x86: dell-laptop: fix broken " Mario.Limonciello
2019-09-25 15:06 ` Andy Shevchenko
2019-09-26 8:11 ` Pali Rohár
2019-09-27 21:19 ` [PATCH v3] platform/x86: dell-laptop: disable " Pacien TRAN-GIRARD
2019-09-27 21:58 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156940489220.8635.14349142383780268583@WARFSTATION \
--to=pacien.trangirard@pacien.net \
--cc=Mario.Limonciello@dell.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®