From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753499AbbCJVqa (ORCPT ); Tue, 10 Mar 2015 17:46:30 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:63670 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752631AbbCJVqY (ORCPT ); Tue, 10 Mar 2015 17:46:24 -0400 From: "Rafael J. Wysocki" To: Linus Walleij Cc: Alexandre Courbot , linux-gpio@vger.kernel.org, Linux Kernel Mailing List , ACPI Devel Maling List , Mika Westerberg Subject: [PATCH 2/2] gpio / ACPI: Use local variable instead of ACPI_HANDLE() Date: Tue, 10 Mar 2015 23:10:01 +0100 Message-ID: <15697166.UNaCUJRTg5@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.19.0+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <4032246.STUT1iRmIk@vostro.rjw.lan> References: <4032246.STUT1iRmIk@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rafael J. Wysocki In acpi_gpiochip_request_interrupts() the handle local variable already contains the value that we want to pass to acpi_walk_resources(), so it is better to use that variable instead of evaluating ACPI_HANDLE() once more for the same device. Signed-off-by: Rafael J. Wysocki --- drivers/gpio/gpiolib-acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-pm/drivers/gpio/gpiolib-acpi.c =================================================================== --- linux-pm.orig/drivers/gpio/gpiolib-acpi.c +++ linux-pm/drivers/gpio/gpiolib-acpi.c @@ -300,7 +300,7 @@ void acpi_gpiochip_request_interrupts(st return; INIT_LIST_HEAD(&acpi_gpio->events); - acpi_walk_resources(ACPI_HANDLE(chip->dev), "_AEI", + acpi_walk_resources(handle, "_AEI", acpi_gpiochip_request_interrupt, acpi_gpio); }