From: Alan Mikhak <alan.mikhak@sifive.com>
To: linux-kernel@vger.kernel.org, martin.petersen@oracle.com,
alexios.zavras@intel.com, ming.lei@redhat.com,
gregkh@linuxfoundation.org, tglx@linutronix.de, jgg@ziepe.ca,
christophe.leroy@c-s.fr, thellstrom@vmware.com,
galpress@amazon.com, palmer@sifive.com, paul.walmsley@sifive.com
Cc: Alan Mikhak <alan.mikhak@sifive.com>
Subject: [PATCH] scatterlist: Comment on pages for sg_set_page()
Date: Tue, 1 Oct 2019 11:32:50 -0700 [thread overview]
Message-ID: <1569954770-11477-1-git-send-email-alan.mikhak@sifive.com> (raw)
From: Alan Mikhak <alan.mikhak@sifive.com>
Update the description of sg_set_page() to communicate current
requirements for the page pointer parameter.
Signed-off-by: Alan Mikhak <alan.mikhak@sifive.com>
---
include/linux/scatterlist.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h
index 6eec50fb36c8..6dda865893aa 100644
--- a/include/linux/scatterlist.h
+++ b/include/linux/scatterlist.h
@@ -112,6 +112,12 @@ static inline void sg_assign_page(struct scatterlist *sg, struct page *page)
* of the page pointer. See sg_page() for looking up the page belonging
* to an sg entry.
*
+ * Scatterlist currently expects the page parameter to be a pointer to
+ * a page that is backed by a page struct.
+ *
+ * Page pointers derived from addresses obtained from ioremap() are
+ * currently not supported since they require use of iomem safe memcpy.
+ *
**/
static inline void sg_set_page(struct scatterlist *sg, struct page *page,
unsigned int len, unsigned int offset)
--
2.7.4
next reply other threads:[~2019-10-01 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 18:32 Alan Mikhak [this message]
2019-10-02 14:27 ` Jason Gunthorpe
2019-10-02 16:18 ` Alan Mikhak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1569954770-11477-1-git-send-email-alan.mikhak@sifive.com \
--to=alan.mikhak@sifive.com \
--cc=alexios.zavras@intel.com \
--cc=christophe.leroy@c-s.fr \
--cc=galpress@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=tglx@linutronix.de \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®