From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F7322F9DB8 for ; Thu, 4 Dec 2025 02:45:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764816338; cv=none; b=QuMynHNjE4kADMfYXgNsPN0pbBXjhA/XHnSocRAYvF3zLfslg8uzq/QiDNWKW5h30LiMNQSzKsUsfFc3c1FFdpYhvCt4sJbfxupqCvRNMBVa3Mn/3r3NOMqB9CReQ4ntGmEsMr857YKvU9vVE0WcGrVWc8gflgI0708PFfjLwtM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764816338; c=relaxed/simple; bh=HIVx64jSl++zSAL3wfQIndyBBOyq1M6NuIIm/yBlHQ4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S1AJI8QLLaxMUTqCzvQ3oYcq8x/ygFnPi7LetJTHDbqAIrrmqyMnetVBatSpzA+FiXDeNTaEJwWc1abukaLU+pdD+LddjBxR/Y/PgXjRL6E+xiHUdENNKeU6HUK2fi3PA+q+g+k/3c6LuD+Dcz9rw6rumSEyAHIklSmViGo8NdQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hPnhsTbZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NYVOnDOs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hPnhsTbZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NYVOnDOs" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B3G7CwT1970147 for ; Thu, 4 Dec 2025 02:45:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mVS7raly54q0rZvgh+jBl9xmb+xtSnb+plPkT836p9k=; b=hPnhsTbZ7fp8xKMh jdhilo8QCLKnWCHEALzpbteXVuG7A7GrxC9JZuU8kQN68l3eLQ0zFnabaVeiAutk 5hQ9+Pll+ozdGOP903ZXY0HdCJEjUNRjHU6jt3PoKXqPIYXZNj/yLS5Msjmltuie 2z/DBSTkE2THajN1GjZP+/dRz1SNab2iSLA7N6Ap/Y8Qspq54tAVHP93CRi5dV+r qWgf4EA4NQ21lzUU7lyHLbekmYzcCR7mOSjrcd96SvE1TdiAo9DqrGuM0psEmn2e p0fLT1jR30Bl7kQpczaL8uFE6M9FYhBdqAYreRPeMk+vKC5jNjqJATpb2L18FxoF MlS1zQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4atjjs2trp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 04 Dec 2025 02:45:31 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-7b90740249dso689177b3a.0 for ; Wed, 03 Dec 2025 18:45:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764816330; x=1765421130; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mVS7raly54q0rZvgh+jBl9xmb+xtSnb+plPkT836p9k=; b=NYVOnDOs2p4EpI9P9rBSIfBaMEJ+6SqWa+TmLqokGlISaDFm2sepV9Ig6N5i8yTTMZ MDt8LTiAISigMxKu9c/+CRBW/YOhCQ/SkVNQZHpoVp17SHEeZQZkzI9mPfHckwjBWL2G yxspVND1sEhKpkItL32fReSQkrto1UQAiXr8caK3mUxKNKSOQpBotBmJhaK+i6atzWQc cOnbEc7Wx3+VduP1GXUt51KHeOd6AHo1eckF1kl4BcK991/eNtz49sjAz4k8u0FTZUJC flClMan6z+4U6iL8LdFba6LBaDsMmDz2hNwaba2NB1yF9DEFyWvVgE1Z/4mUfMsKDF59 WsmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764816330; x=1765421130; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mVS7raly54q0rZvgh+jBl9xmb+xtSnb+plPkT836p9k=; b=fpGl1vVXE0zQo9McRddSmo1YrgBxcNHqg0q2dWzmSocsa7MbCcd2e+CBOPDG6cEt6R sQ3sRRkODjN0fYkZzf95E3DR3iOYfHy3smxSbA6PimwcQPBF0bvhl7LUTVjJFfRgzv8j gQgWUlSBkbJALQ2nV1UO6uHZ06KIMGj/suy1zABFAFocS6GwKA2rWf5NHEL5JbKZDt6+ 4yKLaUr7/240m6aqaJC9kCUEl3Pl6O5E16f9fQ8P0o0z0k5FtWVPrTq2lw+Yb99w1Yqv 6Xwc3NA4f+HWHeguJcuniRsC34Q8152PMpnKBiVxPdtmLDCL6tnjvUkBUWsOYQ7gdyxR ZULg== X-Forwarded-Encrypted: i=1; AJvYcCXWgwlq+jU1gJp66pXDblcZQqnNHozv4r7OyvFaTtQAJ2zr6mPmF2jc00TC0Uio5tcsD/KvQzFFoL17em4=@vger.kernel.org X-Gm-Message-State: AOJu0YwLxYp/4m2lG78S+3aOeSyPZPdiuWBqqZHNQJG7065Aq/FM/VTp s14pEtFGKDPYymCfva2JyCxqGuCsNTq74Y2EFct1qM3jQFF6VOMDy0DQ+pThxqdXem459IQvpdY 1ElW4zGPnt03rWU7iEz3GOr6WSuXECamxkHqKeo3nfYGzQuiWqv3keI56kBRM/BYgpHU= X-Gm-Gg: ASbGncuio3wRmToNlMFarvaCPKPbKhxi/M7zax1zq4wzrL3KaCZxFX48t1GBpatEAwL WMdJyxmYeEeMnhYgsc38vmYQM8IUiI1dbgbWQDjRYyBhP70qUZbQJmvcDyVnuU/NlFKH5tP/QVL GLK5lVweS6/F0QAKoTdyqbLUe2LOX5UVWizjsvhGHx3/vxt+FNva2RelrYXiBZlGjI3zRjQYcAC gI3qS9hGrWSzvaaFA9JqTCTiHo61mIQSXot7H4luGaKu93HIdEzt2d6HKc0KTHeKhHpji7nCXYT dpo5LA574Uwmy23Efl9jm3SAt0x/+0LGPRn+VBeD0t/bzWBXjz/4ExiT+HXP5fYuw82SSIXS2wI zp04QZNWE/sPAbdn+X6kAHtlStzpnyhVCvQp/PtbU/3ejFmTIjhPXSemz9V1Ev0u6UtrvxRdk09 s= X-Received: by 2002:a05:6a00:1803:b0:7b1:79be:1273 with SMTP id d2e1a72fcca58-7e00fbcedaamr5490264b3a.26.1764816330157; Wed, 03 Dec 2025 18:45:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IE37bJ6SuNkL1ibi+kVSbfhO34dJIPCl5xiwPxofyWOKXbjDtL4lt70R3l5q+n/T6TY9GpAbw== X-Received: by 2002:a05:6a00:1803:b0:7b1:79be:1273 with SMTP id d2e1a72fcca58-7e00fbcedaamr5490231b3a.26.1764816329603; Wed, 03 Dec 2025 18:45:29 -0800 (PST) Received: from [10.133.33.165] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7e2a006547fsm370091b3a.21.2025.12.03.18.45.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 18:45:28 -0800 (PST) Message-ID: <156d7def-364d-4fbf-b63f-99e1de657f93@oss.qualcomm.com> Date: Thu, 4 Dec 2025 10:45:21 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/9] coresight: core: Refactoring ctcu_get_active_port and make it generic To: Suzuki K Poulose , Jie Gan , Mike Leach , James Clark , Alexander Shishkin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jinlong Mao , Bjorn Andersson , Konrad Dybcio Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20250908-enable-byte-cntr-for-tmc-v6-0-1db9e621441a@oss.qualcomm.com> <20250908-enable-byte-cntr-for-tmc-v6-1-1db9e621441a@oss.qualcomm.com> <29a61f75-df0b-41da-9c8d-3e2ced0a9ce7@arm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <29a61f75-df0b-41da-9c8d-3e2ced0a9ce7@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 8lG3wrdqZHB7zJd6qJ2o354PW1GbiiP2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA0MDAyMCBTYWx0ZWRfX+qoRrznD58B2 E3zmiHXZn5xRpGtk+tSF5vbXzGEPBhQHyL2b5qBmqA1hQC9xmv2bn8Y/pqT3jqh6nuH9v7pbxD6 6M38DW1DRLa7ImHRA0hDKoYUGXN0eGY0pykTnIf3kLOVNeZ4Lz2UX87xzbDdMs1Gx9XoOxh5Nd8 ckrlHLp/sfoP0h9VixdKtoL+IIMYSlRNp2XIzw0vnkgvOMC6EfxAZXFeGcGa43/6Aa2oWTr+tdj Qdxs1Mga4YAm1ZLyx2ovK5uiXR1YMu5bZnSv+mjMG0gD7+LtNU/HrJCdZ58phpUyNgRBxbXzoPp hxBUUzmESpjGipqTxSZh4LvGAugdAAKsqL7+9K9AU0PORFkTc3fgZTfMv2IrcQYaz80Cpkc1d6/ tMS49Q66BIHaNbLREyVkt02eHfAhQw== X-Proofpoint-GUID: 8lG3wrdqZHB7zJd6qJ2o354PW1GbiiP2 X-Authority-Analysis: v=2.4 cv=ZqDg6t7G c=1 sm=1 tr=0 ts=6930f5cb cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=fsjGGd5fPUumY84vGlEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-04_01,2025-12-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512040020 On 12/4/2025 12:18 AM, Suzuki K Poulose wrote: > On 08/09/2025 03:01, Jie Gan wrote: >> Remove ctcu_get_active_port from CTCU module and add it to the core >> framework. >> >> The port number is crucial for the CTCU device to identify which ETR >> it serves. With the port number we can correctly get required parameters >> of the CTCU device in TMC module. >> >> Reviewed-by: Mike Leach >> Signed-off-by: Jie Gan >> --- >>   drivers/hwtracing/coresight/coresight-core.c      | 24 +++++++++++++ >> ++++++++++ >>   drivers/hwtracing/coresight/coresight-ctcu-core.c | 19 >> +----------------- >>   drivers/hwtracing/coresight/coresight-priv.h      |  2 ++ >>   3 files changed, 27 insertions(+), 18 deletions(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/ >> hwtracing/coresight/coresight-core.c >> index 1accd7cbd54b..042c4fa39e55 100644 >> --- a/drivers/hwtracing/coresight/coresight-core.c >> +++ b/drivers/hwtracing/coresight/coresight-core.c >> @@ -580,6 +580,30 @@ struct coresight_device >> *coresight_get_sink(struct coresight_path *path) >>   } >>   EXPORT_SYMBOL_GPL(coresight_get_sink); >> +/** >> + * coresight_get_in_port_dest: get the in-port number of the dest device >> + * that is connected to the src device. >> + * >> + * @src: csdev of the source device. >> + * @dest: csdev of the destination device. >> + * >> + * Return: port number upon success or -EINVAL for fail. >> + */ >> +int coresight_get_in_port_dest(struct coresight_device *src, > > Please could we make this more explicit : > >     /* >      * Find the input port number at @csdev where a @remote >      * device is connected to. >      */ >     coresight_get_in_port(struct coresight_device *csdev, >                   struct coresight_device *remote) >     { > >     } Hi Suzuki That's make sense for me, will update in next version. Thanks, Jie > Suzuki > >