From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B5FCD5BB5 for ; Tue, 19 Sep 2023 12:56:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232248AbjISM4z (ORCPT ); Tue, 19 Sep 2023 08:56:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231489AbjISM4x (ORCPT ); Tue, 19 Sep 2023 08:56:53 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57D59E3 for ; Tue, 19 Sep 2023 05:56:46 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-9a648f9d8e3so746794466b.1 for ; Tue, 19 Sep 2023 05:56:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695128205; x=1695733005; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aNRRNVww+5807GnHAPONA2RcVUeOwfzBI7YrYLaiKvk=; b=RP8TEhvCe2PBv5I0TFmltmZQk+JEPVzQXWUTXm6q8t8OW9EhnWReEtf9d77XNpxrGZ 7G9WEqw83v+n5+AIekYzhQYfpU+0ZNCnD4nCuTa1sHyDFt9rN4rfgxLqehX6W6oQVhBA tVXp+r6zuRNfwE/P5N1Noorp+1uuwhFluE+eVoglm86w6YttzyUSdQpHb4nYkyertzbz wddv8e/mbR1aS/qIX07nuMTkSmfgFLY1ZBNy8TpKwnh/xKxhoVJQn5rDl6QhufvCGklJ Klwo5GIx4F74dZtzULxzlmW7frgGHOf8zdRLL0Ckcy/BWAvamsaFQgZ4Eq1dDE6varWP oCFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695128205; x=1695733005; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aNRRNVww+5807GnHAPONA2RcVUeOwfzBI7YrYLaiKvk=; b=R//Rp3JwVq3WAFMXHVbMbpjo68X3DEJzXUChFprLU+pGqdinttOKUebk5FjeEBF3sI 2AKIsUu83RzZwkxaiRLR52rCnGYIq7ReqR9cUwSCAf3PSJLPTEBI8Li8zTce3Oo/XBsY QllGnpPLZJEUrB+TWKjYggK5LJV+W1QyCD+0y7cVYUkAUMZKIRwhrMxupXq9qaPlXAbr 664C+oZU72vploVz3SjRCtlphmiRwverOkGnACcLijVoRx7SIr+rk1D48A3Q6OP/wzD8 REpowqFwu9BU8SR+PWoLHJs0NpKq0Nx7O7lDOpYLr1/0HnOM9i6qNsbcyw61tw0jD34A ddoA== X-Gm-Message-State: AOJu0YywJMRio64O+o9PGsLYzMsVlBdLFRDnguY+2fU4slhrVt0a18Sp bpoY2w6VDmjra0yx69BnS77FZA== X-Google-Smtp-Source: AGHT+IELn3QkWc/JwrxzYHVIzfvU2A25NoAvgTcAX3CKqfChLXXYG+NJEhkcxaBBMVrL3zQf+qflAw== X-Received: by 2002:a17:907:60c7:b0:9ad:8a29:f26a with SMTP id hv7-20020a17090760c700b009ad8a29f26amr10237919ejc.63.1695128204786; Tue, 19 Sep 2023 05:56:44 -0700 (PDT) Received: from [172.20.24.238] (static-212-193-78-212.thenetworkfactory.nl. [212.78.193.212]) by smtp.gmail.com with ESMTPSA id mf13-20020a170906cb8d00b0099caf5bed64sm7665767ejb.57.2023.09.19.05.56.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Sep 2023 05:56:44 -0700 (PDT) Message-ID: <156f4705-ca1a-f82e-9282-534a22183f37@linaro.org> Date: Tue, 19 Sep 2023 14:56:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH V2 1/4] dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible Content-Language: en-US To: Sricharan Ramabadhran , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, srinivas.kandagatla@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, thara.gopinath@gmail.com, rafael@kernel.org, daniel.lezcano@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dmitry.baryshkov@linaro.org References: <20230915121504.806672-1-quic_srichara@quicinc.com> <20230915121504.806672-2-quic_srichara@quicinc.com> <03b0cafa-49c7-8838-b116-927c9649cbd3@linaro.org> <1f09339e-b3b5-874c-4874-199e8c7ae890@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/09/2023 14:48, Sricharan Ramabadhran wrote: > > > On 9/19/2023 6:02 PM, Krzysztof Kozlowski wrote: >> On 19/09/2023 09:22, Sricharan Ramabadhran wrote: >>> >>> >>> On 9/15/2023 6:15 PM, Krzysztof Kozlowski wrote: >>>> On 15/09/2023 14:43, Krzysztof Kozlowski wrote: >>>>> On 15/09/2023 14:15, Sricharan Ramabadhran wrote: >>>>>> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt. >>>>>> >>>>>> Signed-off-by: Sricharan Ramabadhran >>>>>> --- >>>>>> [v2] Sorted the compatible and removed example >>>>>> >>>>> >>>>> Reviewed-by: Krzysztof Kozlowski >>>> >>>> No, unreviewed. Your driver says it is not compatible with >>>> qcom,tsens-v1. This does not look right :/ >>>> >>> >>> Yes it is V1 IP, but since there is no RPM, to enable the IP/SENSORS >>> have to do those steps after calling init_common. Similar reason >>> added a new feat as well in patch #2 as well. Hence for this, >>> new compatible was required. >> >> I dud not write about new or old compatible ("compatible" as noun). I >> wrote that it is not compatible ("compatible" as adjective) with v1. >> > > Ho, in that case, yes it is not compatible with V1 init and features > because of 'no rpm'. So in that case, should this be documented > as a separate version of 'V1 without rpm' ? It should not be mixed with regular v1, just as new entry there. I don't think fallback is needed - just use SoC specific compatible. Best regards, Krzysztof