From: "Lukáš Doktor" <ldoktor@redhat.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: a.zummo@towertech.it, john.stultz@linaro.org, tglx@linutronix.de,
sboyd@codeaurora.org, shuah@kernel.org,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] rtc: rtctest: Improve support detection
Date: Tue, 15 Aug 2017 10:20:04 +0200 [thread overview]
Message-ID: <156f7ff1-d1e3-16ea-98a8-969625075c72@redhat.com> (raw)
In-Reply-To: <20170812202206.6phv7fesej42jhxr@piout.net>
[-- Attachment #1.1: Type: text/plain, Size: 2200 bytes --]
Dne 12.8.2017 v 22:22 Alexandre Belloni napsal(a):
> Hi,
>
> On 11/08/2017 at 11:14:55 +0200, Lukáš Doktor wrote:
>> The rtc-generic and opal-rtc are failing to run this test as they do not
>> support all the features. Let's treat the error returns and skip to the
>> following test.
>>
>> Theoretically the test_DATE should be also adjusted, but as it's enabled
>> on demand I think it makes sense to fail in such case.
>>
>> Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
>> ---
>> tools/testing/selftests/timers/rtctest.c | 9 +++++++--
>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/timers/rtctest.c b/tools/testing/selftests/timers/rtctest.c
>> index f61170f..6344842 100644
>> --- a/tools/testing/selftests/timers/rtctest.c
>> +++ b/tools/testing/selftests/timers/rtctest.c
>> @@ -125,7 +125,7 @@ int main(int argc, char **argv)
>> /* Turn on update interrupts (one per second) */
>> retval = ioctl(fd, RTC_UIE_ON, 0);
>> if (retval == -1) {
>> - if (errno == EINVAL) {
>> + if (errno == EINVAL || errno == EINVAL) {
>
> Well, this needs to be fixed.
>
Yes, this chunk is actually not needed anymore (it was based on outdated copy we use in Autotest which had ENOTTY which is probably not needed nowadays). Let me send v2 without this.
Regards,
Lukáš
>> fprintf(stderr,
>> "\n...Update IRQs not supported.\n");
>> goto test_READ;
>> @@ -221,6 +221,11 @@ int main(int argc, char **argv)
>> /* Read the current alarm settings */
>> retval = ioctl(fd, RTC_ALM_READ, &rtc_tm);
>> if (retval == -1) {
>> + if (errno == EINVAL) {
>> + fprintf(stderr,
>> + "\n...EINVAL reading current alarm setting.\n");
>> + goto test_PIE;
>> + }
>> perror("RTC_ALM_READ ioctl");
>> exit(errno);
>> }
>> @@ -231,7 +236,7 @@ int main(int argc, char **argv)
>> /* Enable alarm interrupts */
>> retval = ioctl(fd, RTC_AIE_ON, 0);
>> if (retval == -1) {
>> - if (errno == EINVAL) {
>> + if (errno == EINVAL || errno ==EIO) {
>> fprintf(stderr,
>> "\n...Alarm IRQs not supported.\n");
>> goto test_PIE;
>> --
>> 2.9.4
>>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 502 bytes --]
prev parent reply other threads:[~2017-08-15 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 9:14 [PATCH 0/1] rtc: rtctest: Support opal-rtc and rtc-generic Lukáš Doktor
2017-08-11 9:14 ` [PATCH] rtc: rtctest: Improve support detection Lukáš Doktor
2017-08-12 20:22 ` Alexandre Belloni
2017-08-15 8:20 ` Lukáš Doktor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156f7ff1-d1e3-16ea-98a8-969625075c72@redhat.com \
--to=ldoktor@redhat.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sboyd@codeaurora.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®