From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D72DA36AE7 for ; Tue, 9 Jan 2024 11:08:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X1DBZYSY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704798517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jVq6Bvt43xx2ZZr7NjW5k0lYlPpCHdUkD3QuDPePB8I=; b=X1DBZYSYBkJy8jpVpBGxp+1mact9tg9IAURYSqHiyVFusx3ckdDhRvF+OMtITffRegaY1B pVVHfw14MZLfslVUIpnYB4xwGB3R+Z3t3anYsS5W+4OC/o+kt6pjJC6jL+sEjwgY+1Scgu iWFKKHJb1nRUIy29q7wt1GeFkPLCKjk= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-237-tJeXuIr2MX6fcUVVyYDIeQ-1; Tue, 09 Jan 2024 06:08:34 -0500 X-MC-Unique: tJeXuIr2MX6fcUVVyYDIeQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 560381C05151; Tue, 9 Jan 2024 11:08:33 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83E3740C6EB9; Tue, 9 Jan 2024 11:08:32 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <1542013.1704750095@warthog.procyon.org.uk> To: Matthew Wilcox Cc: dhowells@redhat.com, Lukas Bulwahn , linux-cachefs@redhat.com, linux-fsdevel , Linux Kernel Mailing List Subject: Re: Reference to non-existing CONFIG_NETFS_FSCACHE Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1571879.1704798511.1@warthog.procyon.org.uk> Date: Tue, 09 Jan 2024 11:08:31 +0000 Message-ID: <1571880.1704798511@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 Matthew Wilcox wrote: > > netfs_writepages_begin() has the wait on the fscache folio conditional on > > CONFIG_NETFS_FSCACHE - which doesn't exist. > > > > Fix it to be conditional on CONFIG_FSCACHE instead. > > Why is it conditional at all? Why don't we have a stub function if > CONFIG_FSCACHE is not defined? At this point, I'd rather just change the #ifdef and then (hopefully) next cycle get rid of PG_fscache entirely, rendering this unnecessary. David