From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF949C5DF62 for ; Tue, 5 Nov 2019 20:39:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79517217F5 for ; Tue, 5 Nov 2019 20:39:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729110AbfKEUj5 (ORCPT ); Tue, 5 Nov 2019 15:39:57 -0500 Received: from foss.arm.com ([217.140.110.172]:60572 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725806AbfKEUj5 (ORCPT ); Tue, 5 Nov 2019 15:39:57 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4E3E97B9; Tue, 5 Nov 2019 12:39:56 -0800 (PST) Received: from p8cg001049571a15.arm.com (unknown [10.163.1.23]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C084D3FAD2; Mon, 4 Nov 2019 21:23:36 -0800 (PST) From: Anshuman Khandual To: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Cc: Anshuman Khandual , Ard Biesheuvel Subject: [PATCH] efi: Return EFI_RESERVED_TYPE in efi_mem_type() for absent addresses Date: Tue, 5 Nov 2019 10:53:49 +0530 Message-Id: <1572931429-487-1-git-send-email-anshuman.khandual@arm.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function efi_mem_type() is expected (per documentation above) to return EFI_RESERVED_TYPE when a given physical address is not present in the EFI memory map. Even though EFI_RESERVED_TYPE is not getting checked explicitly anywhere in the callers, it is always better to return expected values. Cc: Ard Biesheuvel Cc: linux-efi@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Anshuman Khandual --- drivers/firmware/efi/efi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c index 69f00f7453a3..bdda90a4601e 100644 --- a/drivers/firmware/efi/efi.c +++ b/drivers/firmware/efi/efi.c @@ -914,7 +914,7 @@ int efi_mem_type(unsigned long phys_addr) (md->num_pages << EFI_PAGE_SHIFT)))) return md->type; } - return -EINVAL; + return EFI_RESERVED_TYPE; } #endif -- 2.20.1