From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF0ECCA9EC7 for ; Tue, 5 Nov 2019 08:34:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A060120869 for ; Tue, 5 Nov 2019 08:34:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="AAfCtRej" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387943AbfKEIe6 (ORCPT ); Tue, 5 Nov 2019 03:34:58 -0500 Received: from mail-m972.mail.163.com ([123.126.97.2]:43602 "EHLO mail-m972.mail.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387575AbfKEIe6 (ORCPT ); Tue, 5 Nov 2019 03:34:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=UmCATjPG/GKR+6fRa5 oRwlQUqq9VmP1kRhoxMz0GB78=; b=AAfCtRej8KmnUcsJgbHv21b8BJBL4z4LbK 0WgcSD02B11JJy8eIYB3pt3scN13PA65kdwqQYTBG42ZVs5DHOUbIHuiUj7Hh6nr q5UmIcpzIeWd7PuCXGgUVfBuehJ/OLUfnfntNVq5n+Mn0OaE6l92a0JmRGyvSrvU uVMabAGNg= Received: from localhost.localdomain (unknown [202.112.113.212]) by smtp2 (Coremail) with SMTP id GtxpCgB3wh8MNMFd8mC3Aw--.239S3; Tue, 05 Nov 2019 16:34:30 +0800 (CST) From: Pan Bian To: Allison Randal , Greg Kroah-Hartman , Thomas Gleixner , Richard Fontana , Kate Stewart Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH] NFC: fdp: fix incorrect free object Date: Tue, 5 Nov 2019 16:34:07 +0800 Message-Id: <1572942847-35209-1-git-send-email-bianpan2016@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: GtxpCgB3wh8MNMFd8mC3Aw--.239S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7Wr4UXFy8Aw13XF1xuFWxWFg_yoW3Jrc_CF srur47ur15CFyfK343ur4FvryUK347Zwn3GF1SgFW3AryUXF4DAw4UZrn7Ar45Ww47Zas8 Ww4DW34rZ3yDCjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU1jNt3UUUUU== X-Originating-IP: [202.112.113.212] X-CM-SenderInfo: held01tdqsiiqw6rljoofrz/xtbBURZkclaD5IoMxAAAsi Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The address of fw_vsc_cfg is on stack. Releasing it with devm_kfree() is incorrect, which may result in a system crash or other security impacts. The expected object to free is *fw_vsc_cfg. Signed-off-by: Pan Bian --- drivers/nfc/fdp/i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/fdp/i2c.c b/drivers/nfc/fdp/i2c.c index 1cd113c8d7cb..ad0abb1f0bae 100644 --- a/drivers/nfc/fdp/i2c.c +++ b/drivers/nfc/fdp/i2c.c @@ -259,7 +259,7 @@ static void fdp_nci_i2c_read_device_properties(struct device *dev, *fw_vsc_cfg, len); if (r) { - devm_kfree(dev, fw_vsc_cfg); + devm_kfree(dev, *fw_vsc_cfg); goto vsc_read_err; } } else { -- 2.7.4