mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jori Koolstra <jkoolstra@xs4all.nl>
To: Christian Brauner <brauner@kernel.org>, NeilBrown <neil@brown.name>
Cc: linux-fsdevel@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] fs/namei.c: fix coding style in atomic_open() and lookup_open()
Date: Fri, 31 Jul 2026 11:20:04 +0200 (CEST)	[thread overview]
Message-ID: <1573100765.693247.1785489604226@kpc.webmail.kpnmail.nl> (raw)
In-Reply-To: <20260731-work-lookup-fixes-v1-3-2412b85cf65c@kernel.org>


> Op 31-07-2026 10:36 CEST schreef Christian Brauner <brauner@kernel.org>:
> 
>  
> Commit 4886c80eef20 ("vfs: call audit_inode_child() in lookup_open() on
> failure") indented a continuation line with spaces, left three
> declarations without a following blank line and used a trailing */ on the
> last line of a block comment.  Clean all of that up, no functional change.
> 
> Fixes: 4886c80eef20 ("vfs: call audit_inode_child() in lookup_open() on failure")
> Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
> 

I know checkpatch complains about this, but since namei.c has a bit of its own
style, I didn't pay too much attention to that. Do we adhere strictly to
checkpatch style in VFS? Anyhow, I'll add new lines after declarations in the
future :)

Thanks,
Jori.

  reply	other threads:[~2026-07-31  9:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31  8:36 [PATCH 0/3] fs/namei.c: comment and coding style fixups Christian Brauner
2026-07-31  8:36 ` [PATCH 1/3] fs/namei.c: update stale comments in lookup_open() Christian Brauner
2026-07-31  8:36 ` [PATCH 2/3] fs/namei.c: fix kerneldoc of atomic_open() and vfs_lookup_open() Christian Brauner
2026-07-31  9:11   ` Jori Koolstra
2026-07-31 10:11     ` Christian Brauner
2026-07-31  8:36 ` [PATCH 3/3] fs/namei.c: fix coding style in atomic_open() and lookup_open() Christian Brauner
2026-07-31  9:20   ` Jori Koolstra [this message]
2026-07-31 10:01     ` Christian Brauner
2026-07-31  9:08 ` [PATCH 0/3] fs/namei.c: comment and coding style fixups NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1573100765.693247.1785489604226@kpc.webmail.kpnmail.nl \
    --to=jkoolstra@xs4all.nl \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®