From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jan Kara <jack@suse.com>
Cc: Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>
Subject: [PATCH] fs/quota: use unsigned int helper for sysctl fs.quota.*
Date: Thu, 07 Nov 2019 13:08:11 +0300 [thread overview]
Message-ID: <157312129151.3890.6076128127053624123.stgit@buzz> (raw)
Report counters as unsigned, otherwise they turn negative at overflow:
# sysctl fs.quota
fs.quota.allocated_dquots = 22327
fs.quota.cache_hits = -489852115
fs.quota.drops = -487288718
fs.quota.free_dquots = 22083
fs.quota.lookups = -486883485
fs.quota.reads = 22327
fs.quota.syncs = 335064
fs.quota.writes = 3088689
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
---
fs/quota/dquot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index 6e826b454082..606e1e39674b 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -2865,7 +2865,7 @@ static int do_proc_dqstats(struct ctl_table *table, int write,
/* Update global table */
dqstats.stat[type] =
percpu_counter_sum_positive(&dqstats.counter[type]);
- return proc_dointvec(table, write, buffer, lenp, ppos);
+ return proc_douintvec(table, write, buffer, lenp, ppos);
}
static struct ctl_table fs_dqstats_table[] = {
next reply other threads:[~2019-11-07 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 10:08 Konstantin Khlebnikov [this message]
2019-11-07 11:50 ` Jan Kara
2019-11-07 17:59 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157312129151.3890.6076128127053624123.stgit@buzz \
--to=khlebnikov@yandex-team.ru \
--cc=dmtrmonakhov@yandex-team.ru \
--cc=jack@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®