From: David Mosberger <davidm@napali.hpl.hp.com>
To: "R Sreelatha" <rsreelat@in.ibm.com>
Cc: linux-ia64@linuxia64.org, davem@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: patch for IA64: fix do_sys32_msgrcv bad address error.
Date: Thu, 5 Sep 2002 09:51:48 -0700 [thread overview]
Message-ID: <15735.35748.328193.108301@napali.hpl.hp.com> (raw)
In-Reply-To: <OFFB350C4A.BB78D4E6-ON65256C2B.004CF605@in.ibm.com>
>>>>> On Thu, 5 Sep 2002 19:46:40 +0530, "R Sreelatha" <rsreelat@in.ibm.com> said:
R> In sys_ia32.c file, in the do_sys32_msgrcv() function call, the
R> value of ipck.msgp is interpreted as a 64 bit address, whereas it
R> is a 32 bit address. Hence, do_sys32_msgrcv() finally returns
R> EFAULT(bad address) error. The patch below takes care of this by
R> type casting ipck.msgp to type u32. The patch is created for
R> 2.5.32 version of the kernel.
Yes, this was obviously broken. I committed the attached patch to my 2.5
tree.
--david
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.532 -> 1.533
# arch/ia64/ia32/sys_ia32.c 1.18 -> 1.19
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 02/09/05 davidm@tiger.hpl.hp.com 1.533
# ia64: Fix x86 struct ipc_kludge (reported by R Sreelatha, fix proposed by
# Dave Miller).
# --------------------------------------------
#
diff -Nru a/arch/ia64/ia32/sys_ia32.c b/arch/ia64/ia32/sys_ia32.c
--- a/arch/ia64/ia32/sys_ia32.c Thu Sep 5 09:51:05 2002
+++ b/arch/ia64/ia32/sys_ia32.c Thu Sep 5 09:51:05 2002
@@ -2111,8 +2111,8 @@
};
struct ipc_kludge {
- struct msgbuf *msgp;
- long msgtyp;
+ u32 msgp;
+ s32 msgtyp;
};
#define SEMOP 1
next prev parent reply other threads:[~2002-09-05 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-05 14:16 R Sreelatha
2002-09-05 14:26 ` David S. Miller
2002-09-05 16:51 ` David Mosberger [this message]
2002-09-05 16:43 ` [Linux-ia64] " Don Dugger
2002-09-06 3:19 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15735.35748.328193.108301@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=davem@redhat.com \
--cc=davidm@hpl.hp.com \
--cc=linux-ia64@linuxia64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rsreelat@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®