From: Vincent Guittot <vincent.guittot@linaro.org>
To: linux-kernel@vger.kernel.org, mingo@redhat.com,
peterz@infradead.org, dietmar.eggemann@arm.com,
juri.lelli@redhat.com, rostedt@goodmis.org, mgorman@suse.de
Cc: bsegall@google.com, Vincent Guittot <vincent.guittot@linaro.org>
Subject: [PATCH] sched/fair: add comments for group_type and balancing at SD_NUMA level
Date: Tue, 12 Nov 2019 15:50:43 +0100 [thread overview]
Message-ID: <1573570243-1903-1-git-send-email-vincent.guittot@linaro.org> (raw)
Add comments to describe each state of goup_type and to add some details
about the load balance at NUMA level.
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
kernel/sched/fair.c | 29 ++++++++++++++++++++++++++++-
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index c93d534..268e441 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6986,11 +6986,34 @@ enum fbq_type { regular, remote, all };
* group. see update_sd_pick_busiest().
*/
enum group_type {
+ /*
+ * The group has spare capacity that can be used to process more work.
+ */
group_has_spare = 0,
+ /*
+ * The group is fully used and the tasks don't compete for more CPU
+ * cycles. Nevetheless, some tasks might wait before running.
+ */
group_fully_busy,
+ /*
+ * One task doesn't fit with CPU's capacity and must be migrated on a
+ * more powerful CPU.
+ */
group_misfit_task,
+ /*
+ * One local CPU with higher capacity is available and task should be
+ * migrated on it instead on current CPU.
+ */
group_asym_packing,
+ /*
+ * The tasks affinity prevents the scheduler to balance the load across
+ * the system.
+ */
group_imbalanced,
+ /*
+ * The CPU is overloaded and can't provide expected CPU cycles to all
+ * tasks.
+ */
group_overloaded
};
@@ -8608,7 +8631,11 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
/*
* Try to use spare capacity of local group without overloading it or
- * emptying busiest
+ * emptying busiest.
+ * XXX Spreading tasks across numa nodes is not always the best policy
+ * and special cares should be taken for SD_NUMA domain level before
+ * spreading the tasks. For now, load_balance() fully relies on
+ * NUMA_BALANCING and fbq_classify_group/rq to overide the decision.
*/
if (local->group_type == group_has_spare) {
if (busiest->group_type > group_fully_busy) {
--
2.7.4
next reply other threads:[~2019-11-12 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 14:50 Vincent Guittot [this message]
2019-11-12 17:42 ` Valentin Schneider
2019-11-18 13:34 ` [PATCH v2] " Ingo Molnar
2019-11-18 14:06 ` Valentin Schneider
2019-11-18 17:42 ` [tip: sched/core] sched/fair: Add " tip-bot2 for Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573570243-1903-1-git-send-email-vincent.guittot@linaro.org \
--to=vincent.guittot@linaro.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®