From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66A1441A926 for ; Tue, 18 Aug 2026 08:38:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787042329; cv=none; b=hSEDSrEdyQML6BB57HrrJmHcptYIWU96cN5ltxJxJJEcgEVrH/Y9FocE/6hX5PLGzfERaNoLD/Cl67iQXWT2lf3UABuaC4nMqNE19uiSihPYo4fxodTBU/dBC4vD+QxQJTi4yfRalzrUj402jtrq9WCY3O4OHGsTCuYnWfop7Hs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787042329; c=relaxed/simple; bh=qvV3xM68RvU2/pgZZw2BG+Ugd+rpYybGwNhzYpB0hjo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KxIkyFdkLRBredSSG7QQlnTIRwapRdB4GfCxI79ZJTUVoxL6D5PzwWKoI9Hg3+HcH/G3lroXwomiT7BmUrE+iT2Rb9PfF7LJiBGhkXV6RXvza00fZhuqWPq5A9uBn0/2cNWW9WOjqTQShD4ezVlAQRgT3rh+N1FnVJjgcyKtNso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oyDFi5/5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MN41WODg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oyDFi5/5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MN41WODg" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67I8BIZm1061658 for ; Tue, 18 Aug 2026 08:38:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= N9sDXi7RWuCc/eU+m27D8sATScrygYetGNs5pLhTApI=; b=oyDFi5/5cIIQP6lH AuFccvYs6L2Tv8D3SlyDKGxnmS9dGR8hg/QcmXW1yH+OocJGTmYVY4IHI6OKwvt1 mTXLedrOk7yfK5ajik2/RiNycWew04C3FiriuFH/QdvD8egTetweEtwNBjhMaa1t AUs/8VCCtb1Ay3nHR6NysLcxMkMtVuJtPXtKa8sJc3cwr1VuLe/3VTxcCQx9LbdL G2dYvgHZLL3SzO6W12zNOPSFZqnEcWoE+yk56RnWDQyU/qdIOeCI8EDfO18rgE72 NuTXRikZ1huYsasjbvDzPEuagmpPXeXlLfRTMVcdfEl9hmriw2ecZ0HvV0NFPSCF aYWwtg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4fvp13ww-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 08:38:47 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-936bc854d04so20082385a.3 for ; Tue, 18 Aug 2026 01:38:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787042326; x=1787647126; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=N9sDXi7RWuCc/eU+m27D8sATScrygYetGNs5pLhTApI=; b=MN41WODgHN6BmjV8VFpkFvFQD/i0xPh6ubl5KCl7d28UucmC4MTUGRCNhPS8hg+1OQ zgwK/GQcJRtPw0fZTIL+36anFV1YThLAkh4uH/8IUyJd9gwwbL1jJ/3+GUdt+fss8MpU UxZGf0z3zD3VSeBsUzN0MhqC62S2HvZwGGhGrF/VXthZpzOidK4/gShycp26rVdmZgYD rmpcfQFU0frYrUCYvUGvCnIYE/+8zCfQ8IVb/AgLKAKgaob4K0WbDy4ts8wB7E+45L7R dTh6QURSRkkEpC4uaD7XBEqflIWYrTFjt+0jdPNcBAsW8jR3uBiX3mpuBCAGpi/Bd+nV nmpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787042326; x=1787647126; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=N9sDXi7RWuCc/eU+m27D8sATScrygYetGNs5pLhTApI=; b=SSd4qNbBFOSgyuSpSyPWcaBM3fdWTBTbXa5sOtI3eK4NaFgIO7LwqNid5ImWAUimjT EIVk8R4OvUKxnRXVNqZHUZrEE9NZt4tplfnJLMGzN9RNmlv/mjfZD5r/Fe2JnMYNnoFi oUns/4EfmpZNy+xh1QfNhNl4/f14Dh0siYs+/+LSe2zJelEVdQ7Z7yuGP6pjB3HHrpag 9CzcHShsRDhnkNO+RTch78Mc+828+C1pDAxD50EL25GRy1EQl5cQa6GiwZox/T0p1VXy b5VXoh+RduYsr4/VZTzOoZAE8yTMJw2KpTzhcm9kIy1jQqa83bI4MjP62+Mt9tMYiZhn ip2w== X-Forwarded-Encrypted: i=1; AHgh+RpYnSzdiOJZ6ZZx5b2lZd7wyx0cG2p+yoDoRuaYTie7XRi7g4oqP8JdZeDMgpZfsRa3exl+WjwcNoMVygM=@vger.kernel.org X-Gm-Message-State: AOJu0YyRBkvh2g6fNWAuURPNq2r1ib1iQSdEYzzj8ajyuuSbt5dcFanL +Q7GAC4zNy7vqkpfvBXz1dXAWE2W2SDljDx0KzeTLJgwYJe88/LbDUjgyBFeFhthQU0vv9zXDtz Zzx+5d7zjWa3n+EP6To3bf6IPuhsj4lTr+N4I6GKLBSqJPhmcmDj43f7ru8QoEYYj3Eo= X-Gm-Gg: AR+sD10+UfBq1fI2WpOdq1BpuKwLkgGP9BC6+XeURbJjjLWdg3mgPusGweZgXyfBO83 4CoWLdnCylWjNXQyJEJKd/Ej8TT1dc7m74jXlmBG9FNB6rcdM1OkTvY7qDROa+hy4Uu3PBJSbPK LcTWLxSDkhZSatSfh+rKjKxhglpwDMxklr/I9wF0oI2B9hOuJJteFHpXQDjKV1ggVTSAe2tSYzX di1FiJjSGW0wbbv2prPO8LXwPDqkMC+0ihW3CUausMvX2P4BCBl5dn08h03/czFGVL1YJFNGgj8 Isvc6n+2UxaseOD/nGCM/j9cQPdbr/lPn+UZd6M/Q1wnt9M8d88jqtQS8HZnYwqyHthT5gkCcFV dsDXuU/8o5WqECMnxOW4YlAqX X-Received: by 2002:a05:620a:3183:b0:92b:14bc:7936 with SMTP id af79cd13be357-936d22401efmr2303230285a.1.1787042326617; Tue, 18 Aug 2026 01:38:46 -0700 (PDT) X-Received: by 2002:a05:620a:3183:b0:92b:14bc:7936 with SMTP id af79cd13be357-936d22401efmr2303228785a.1.1787042326184; Tue, 18 Aug 2026 01:38:46 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c217fed68f9sm152768166b.27.2026.08.18.01.38.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 01:38:45 -0700 (PDT) Message-ID: <15740cab-8485-4887-96dc-b5895a7d7656@oss.qualcomm.com> Date: Tue, 18 Aug 2026 10:38:43 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: qcom: smem: Fix signedness bug To: Ethan Tidmore , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260818023441.891274-1-ethantidmore06@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260818023441.891274-1-ethantidmore06@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: iXJXOobppxVpjkqx-c8Hlca91aQ2dWjP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDA2MyBTYWx0ZWRfX6VYtWVEmEBZ1 u2jTDI/dIP8GgN0P1TV3U+KR3ZSj6S7uh7nm7VJ7SeAP7Y6vIczAZyseHImmdpWJvTxkYoSW/y5 NzXgY3uZauFv6wLBuK3UoqYuz+wAk3kQuhh5QNM9kQy6DhMDwyib+XAjMASLe9ybcxqjRmG3t2E UsMzb/HwPlJ8osEZKprNZzW04uv7d+OKZzzEtTRUrNJQuMBgwwrvEIFZd7hDlbyH3ukzFvWj+wm M78Zssua3PRRTLMygH0KTbWcSAZmDWxdY8WY1gq5NBm0o8XAKOFAhGg6aQT0wjd4fSvEQI4XFN0 UaTGhK0E7JX5TJkxc0cdTnO1ILPP4ShwDX8FK9S7bSzHIjULK5xWpF5jIJ3mPfRNerx4ug4h1/N JsW+bO6mE24HdisfuAFE20foSkNqjTch2DLsLqDx7hKKd/8+0HPU8mtteX/gwkjyECZ3Rdi4HhD i4E5I8T8UR2ZsaThWKA== X-Authority-Analysis: v=2.4 cv=K/IS2SWI c=1 sm=1 tr=0 ts=6a841a17 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=0uNNTOp9MGPMGIwATOAA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDA2MyBTYWx0ZWRfX29IA3sNHrMeV kPlsvfpPOoYPTZ0MqW6JHiLGJB+fdrdBR/GqOFw8jY+ZR1RiqMKsHVfBTchvYmEMjy0OrlQQT/H DcxQhajmF4YSdpxr9Izj2xybJsF3rcQ= X-Proofpoint-GUID: iXJXOobppxVpjkqx-c8Hlca91aQ2dWjP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-17_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 priorityscore=1501 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180063 On 8/18/26 4:34 AM, Ethan Tidmore wrote: > The function smem_dram_infer_struct_version() returns negative error > codes and 'ver' is an enum, which makes subsequent condition (ver < 0) > always impossible. > > Fixes: 1d234eeafc56a ("soc: qcom: smem: Expose DDR data from SMEM") > Signed-off-by: Ethan Tidmore > --- We already got another fix for that: https://lore.kernel.org/linux-arm-msm/an1toQ-acGR0kOWj@stanley.mountain/ Konrad