From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Kangjie Lu <kjlu@umn.edu>
Cc: pakki001@umn.edu, "David S. Miller" <davem@davemloft.net>,
"Vladimir Zapolskiy" <vladimir_zapolskiy@mentor.com>,
"Simon Horman" <horms+renesas@verge.net.au>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Andrew Lunn" <andrew@lunn.ch>,
"Magnus Damm" <damm+renesas@opensource.se>,
"Kazuya Mizuguchi" <kazuya.mizuguchi.ks@renesas.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ravb_main: fix a missing check of of_get_phy_mode
Date: Tue, 12 Mar 2019 10:42:10 +0300 [thread overview]
Message-ID: <1574a042-b614-27e1-e149-4097781824e7@cogentembedded.com> (raw)
In-Reply-To: <076a4b31-3e83-9e3d-81a7-55bb7f25a37f@cogentembedded.com>
On 12.03.2019 10:38, Sergei Shtylyov wrote:
>> of_get_phy_mode may fail and return a negative error code;
>> the fix checks the return value of of_get_phy_mode and
>> goes to out_release if it fails.
>>
>> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
>> ---
>> drivers/net/ethernet/renesas/ravb_main.c | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c
>> b/drivers/net/ethernet/renesas/ravb_main.c
>> index d28c8f9ca55b..791b6842eb12 100644
>> --- a/drivers/net/ethernet/renesas/ravb_main.c
>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
>> @@ -1996,6 +1996,7 @@ static int ravb_probe(struct platform_device *pdev)
>> int error, irq, q;
>> struct resource *res;
>> int i;
>> + int ret;
>
> There's the 'error' variable already for such things, use it.
Please ignore that. But the variable could be named 'interface' or
somesuch. :-)
[...]
MBR, Sergei
prev parent reply other threads:[~2019-03-12 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 6:38 Kangjie Lu
2019-03-12 7:38 ` Sergei Shtylyov
2019-03-12 7:42 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1574a042-b614-27e1-e149-4097781824e7@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=andrew@lunn.ch \
--cc=damm+renesas@opensource.se \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=kazuya.mizuguchi.ks@renesas.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pakki001@umn.edu \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®