mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Luca Weiss <luca.weiss@fairphone.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: dt: submitting-patches: Remove possible confusion of combining DTS
Date: Wed, 25 Feb 2026 16:58:57 +0100	[thread overview]
Message-ID: <15751da9-5545-4d07-9f60-b272dc2583c0@oss.qualcomm.com> (raw)
In-Reply-To: <DGNZQA7LKJ3N.25LB4X3HW1N6K@fairphone.com>

On 25/02/2026 12:02, Luca Weiss wrote:
> Hi Krzysztof,
> 
> On Wed Feb 25, 2026 at 11:59 AM CET, Krzysztof Kozlowski wrote:
>> DTS patches were always expected to be either sent separately or put at
>> the end of patchset, but the first part of paragraph regarding this rule
>> used a "should be placed at the end of patchset" phrase which might
>> create wrong impression. This "should be" about order of patches applies
>> only to the case when DTS is combined into this patchset.
>>
>> Suggested-by: Luca Weiss <luca.weiss@fairphone.com>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> ---
>>  Documentation/devicetree/bindings/submitting-patches.rst | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/submitting-patches.rst b/Documentation/devicetree/bindings/submitting-patches.rst
>> index 81e27e50f905..2a5533f68830 100644
>> --- a/Documentation/devicetree/bindings/submitting-patches.rst
>> +++ b/Documentation/devicetree/bindings/submitting-patches.rst
>> @@ -64,9 +64,10 @@ I. For patch submitters
>>  
>>    7) DTS is treated in general as driver-independent hardware description, thus
>>       any DTS patches, regardless whether using existing or new bindings, should
>> -     be placed at the end of patchset to indicate no dependency of drivers on
>> -     the DTS.  DTS will be anyway applied through separate tree or branch, so
>> -     different order would indicate the series is non-bisectable.
>> +     be a separate posting or, when combined with driver patches, placed at the
> 
> "when combined with driver patches"
> 
> Is there some guidance *when* this is appropriate and when it's not?

It depends what maintainer wants, so depends which subsystem you target.
Several maintainers take everything or nothing, exactly for the reasons
I explained on IRC, thus for them you cannot include DTS.

Please understand that DTS is soc thus another subsystem in such
patchset, therefore, unless you send patchset to drivers/soc + DTS, then
you are always mixing at least two subsystems.

> 
> For example would touchscreen bindings & driver, and dts addition be
> appropriate to combine into one patch series?
> 
> From our discussion on IRC, you said a series covering 3 or 4 subsystems
> is too much and they should be split.

Mixing two is fine (with respect to rule from my first paragraph).
Mixing three is already discouraged, mixing four is too much, unless
subsystem maintainers do not care.


Best regards,
Krzysztof

      reply	other threads:[~2026-02-25 15:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 10:59 Krzysztof Kozlowski
2026-02-25 11:02 ` Luca Weiss
2026-02-25 15:58   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15751da9-5545-4d07-9f60-b272dc2583c0@oss.qualcomm.com \
    --to=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®