From: Brent Lu <brent.lu@intel.com>
To: alsa-devel@alsa-project.org
Cc: Support Opensource <support.opensource@diasemi.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org, Brent Lu <brent.lu@intel.com>
Subject: [PATCH] ASoC: da7219: remove SRM lock check retry
Date: Tue, 3 Dec 2019 15:31:05 +0800 [thread overview]
Message-ID: <1575358265-17905-1-git-send-email-brent.lu@intel.com> (raw)
For platforms not able to provide WCLK in the PREPARED runtime state, it
takes 400ms for codec driver to print the message "SRM failed to lock" in
the da7219_dai_event() function which is called when DAPM widgets are
powering up. The latency penalty to audio input/output is too much so the
retry (8 times) and delay (50ms each retry) are removed.
Another reason is current Cold output latency requirement in Android CDD is
500ms but will be reduced to 200ms for 2021 platforms. With the 400ms
latency it would be difficult to pass the Android CTS test.
Signed-off-by: Brent Lu <brent.lu@intel.com>
---
sound/soc/codecs/da7219.c | 3 ++-
sound/soc/codecs/da7219.h | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
index f83a6ea..042e701 100644
--- a/sound/soc/codecs/da7219.c
+++ b/sound/soc/codecs/da7219.c
@@ -833,7 +833,8 @@ static int da7219_dai_event(struct snd_soc_dapm_widget *w,
srm_lock = true;
} else {
++i;
- msleep(50);
+ if (i < DA7219_SRM_CHECK_RETRIES)
+ msleep(50);
}
} while ((i < DA7219_SRM_CHECK_RETRIES) && (!srm_lock));
diff --git a/sound/soc/codecs/da7219.h b/sound/soc/codecs/da7219.h
index 88b67fe..3149986 100644
--- a/sound/soc/codecs/da7219.h
+++ b/sound/soc/codecs/da7219.h
@@ -770,7 +770,7 @@
#define DA7219_PLL_INDIV_36_TO_54_MHZ_VAL 16
/* SRM */
-#define DA7219_SRM_CHECK_RETRIES 8
+#define DA7219_SRM_CHECK_RETRIES 1
/* System Controller */
#define DA7219_SYS_STAT_CHECK_RETRIES 6
--
2.7.4
next reply other threads:[~2019-12-03 7:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 7:31 Brent Lu [this message]
2019-12-03 9:46 ` Adam Thomson
2019-12-03 10:32 ` Lu, Brent
2019-12-03 10:57 ` Adam Thomson
2019-12-03 14:36 ` Lu, Brent
2019-12-03 14:57 ` Adam Thomson
2019-12-03 15:23 ` Lu, Brent
2019-12-03 17:15 ` Adam Thomson
2019-12-03 13:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1575358265-17905-1-git-send-email-brent.lu@intel.com \
--to=brent.lu@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®