From: Nikita Danilov <Nikita@Namesys.COM>
To: Andrew Morton <akpm@digeo.com>
Cc: Linux Kernel Mailing List <Linux-Kernel@vger.kernel.org>,
Alexander Viro <viro@math.psu.edu>
Subject: Re: locking rules for ->dirty_inode()
Date: Mon, 23 Sep 2002 20:32:52 +0400 [thread overview]
Message-ID: <15759.16948.319035.270576@laputa.namesys.com> (raw)
In-Reply-To: <3D8BA407.E2BFF7E8@digeo.com>
Andrew Morton writes:
> Nikita Danilov wrote:
> >
> > Hello,
> >
> > Documentation/filesystems/Locking states that all super operations may
> > block, but __set_page_dirty_buffers() calls
> >
> > __mark_inode_dirty()->s_op->dirty_inode()
> >
> > under mapping->private_lock spin lock.
>
> Actually it doesn't. We do not call down into the filesystem
> for I_DIRTY_PAGES.
>
> set_page_dirty() is already called under locks, via __free_pte (pagetable
> teardown). 2.4 does this as well.
Cannot find __free_pte, it is only mentioned in comments in mm/filemap.c
and include/asm-generic/tlb.h.
>
> But I'll make the change anyway. I think it removes any
> ranking requirements between mapping->page_lock and
> mapping->private_lock, which is always a nice thing.
Nikita.
next prev parent reply other threads:[~2002-09-23 19:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-20 15:00 Nikita Danilov
2002-09-20 15:52 ` Andrew Morton
2002-09-20 16:32 ` Nikita Danilov
2002-09-20 16:47 ` Andrew Morton
2002-09-20 17:32 ` Nikita Danilov
2002-09-20 18:21 ` Hans Reiser
2002-09-20 22:41 ` Andrew Morton
2002-09-23 16:32 ` Nikita Danilov [this message]
2002-09-23 16:42 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15759.16948.319035.270576@laputa.namesys.com \
--to=nikita@namesys.com \
--cc=Linux-Kernel@vger.kernel.org \
--cc=akpm@digeo.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®