From: Igor Druzhinin <igor.druzhinin@citrix.com>
To: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <hare@suse.de>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>,
"Igor Druzhinin" <igor.druzhinin@citrix.com>
Subject: [PATCH 1/2] scsi: libfc: free response frame from GPN_ID
Date: Tue, 10 Dec 2019 16:57:29 +0000 [thread overview]
Message-ID: <1575997050-12959-2-git-send-email-igor.druzhinin@citrix.com> (raw)
In-Reply-To: <1575997050-12959-1-git-send-email-igor.druzhinin@citrix.com>
fc_disc_gpn_id_resp() should be the last function using it so free it
here to avoid memory leak.
Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
---
drivers/scsi/libfc/fc_disc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c
index 9c5f7c9..2b865c6 100644
--- a/drivers/scsi/libfc/fc_disc.c
+++ b/drivers/scsi/libfc/fc_disc.c
@@ -628,6 +628,8 @@ static void fc_disc_gpn_id_resp(struct fc_seq *sp, struct fc_frame *fp,
}
out:
kref_put(&rdata->kref, fc_rport_destroy);
+ if (!IS_ERR(fp))
+ fc_frame_free(fp);
}
/**
--
2.7.4
next prev parent reply other threads:[~2019-12-10 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 16:57 [PATCH 0/2] Fixing libfc memory leaks Igor Druzhinin
2019-12-10 16:57 ` Igor Druzhinin [this message]
2019-12-10 16:57 ` [PATCH 2/2] scsi: libfc: drop extra rport reference in fc_rport_create() Igor Druzhinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1575997050-12959-2-git-send-email-igor.druzhinin@citrix.com \
--to=igor.druzhinin@citrix.com \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®