From: Kishon Vijay Abraham I <kishon@ti.com>
To: Scott Branden <scott.branden@broadcom.com>,
Ray Jui <ray.jui@broadcom.com>
Cc: <linux-kernel@vger.kernel.org>,
<bcm-kernel-feedback-list@broadcom.com>,
Qingmin Liu <qingmin.liu@broadcom.com>
Subject: Re: [PATCH] phy: bcm-sr-pcie: Change operation when PIPEMUX=1
Date: Wed, 6 Feb 2019 17:46:15 +0530 [thread overview]
Message-ID: <1575bf5c-7dff-6884-b2a2-5dcb5de4debd@ti.com> (raw)
In-Reply-To: <ff198f05-41bb-2c4e-6d28-7a4c0960646e@broadcom.com>
On 05/02/19 12:51 AM, Scott Branden wrote:
> Looks good.
>
> On 2019-02-04 11:07 a.m., Ray Jui wrote:
>> From: Qingmin Liu <qingmin.liu@broadcom.com>
>>
>> When PIPEMIX=1, change the operation from 2x8 EP to 1x8 EP + 1x8 RC.
>>
>> Signed-off-by: Qingmin Liu <qingmin.liu@broadcom.com>
>> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> Acked-by: Scott Branden <scott.branden@broadcom.com>
merged, thanks.
-Kishon
>> ---
>> drivers/phy/broadcom/phy-bcm-sr-pcie.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/phy/broadcom/phy-bcm-sr-pcie.c
>> b/drivers/phy/broadcom/phy-bcm-sr-pcie.c
>> index c10e95f86de5..96a3af126a78 100644
>> --- a/drivers/phy/broadcom/phy-bcm-sr-pcie.c
>> +++ b/drivers/phy/broadcom/phy-bcm-sr-pcie.c
>> @@ -78,8 +78,8 @@ struct sr_pcie_phy_core {
>> static const u8 pipemux_table[] = {
>> /* PIPEMUX = 0, EP 1x16 */
>> 0x00,
>> - /* PIPEMUX = 1, EP 2x8 */
>> - 0x00,
>> + /* PIPEMUX = 1, EP 1x8 + RC 1x8, core 7 */
>> + 0x80,
>> /* PIPEMUX = 2, EP 4x4 */
>> 0x00,
>> /* PIPEMUX = 3, RC 2x8, cores 0, 7 */
prev parent reply other threads:[~2019-02-06 12:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 19:07 Ray Jui
2019-02-04 19:21 ` Scott Branden
2019-02-06 12:16 ` Kishon Vijay Abraham I [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1575bf5c-7dff-6884-b2a2-5dcb5de4debd@ti.com \
--to=kishon@ti.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qingmin.liu@broadcom.com \
--cc=ray.jui@broadcom.com \
--cc=scott.branden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome