From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ED75C2D0C9 for ; Fri, 13 Dec 2019 00:11:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBCCC206E2 for ; Fri, 13 Dec 2019 00:11:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="hdyXdhgs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731809AbfLMALd (ORCPT ); Thu, 12 Dec 2019 19:11:33 -0500 Received: from mail-pj1-f68.google.com ([209.85.216.68]:37933 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731659AbfLMALc (ORCPT ); Thu, 12 Dec 2019 19:11:32 -0500 Received: by mail-pj1-f68.google.com with SMTP id l4so348751pjt.5 for ; Thu, 12 Dec 2019 16:11:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google; h=from:to:cc:subject:date:message-id; bh=Pd7GfhuUEHJZyG7XGzIe2UpFrPycUVkSSTmNupOIeC4=; b=hdyXdhgs3C5VDni3JTL3oqICCy8sXPNZRcfGRPW64b6uE9svSqesYtaqTue5KPGmVX HS/Zo6qzuGCh0EbVkil4fz5EfC3eiURBwkVEGLnsgttb1ZkNgN4sqqFrYPTurc3BEP1K UJ3ZTwXjIDZ97hVCII0xkaiMlG9nmq8tPeXDQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Pd7GfhuUEHJZyG7XGzIe2UpFrPycUVkSSTmNupOIeC4=; b=cnWO2DMcshc1474AqnpZboluYnnDwsCIP6ZW8XT5Tj9q6oWTGcS3voDLrR2/EJ4t6+ xVo1vmPJPnFqiaiQ8zKNyfv3rcZxQ1GHaNANl5MyxVCXMym00LL1rjPh/eahaTFzEZmQ +jtD9G1MNOJdFXj+KrA74L6pqv9UpnPPEVwxV6lzZmcnqc/x3XGkAIzXpjAgBSmH7bRg Gn3cBQsVOtl6X3BbTHzZ8CA0MUfvhyF68T/Yr5K7662H/GRZVttMkU7c3JOOOC0ZyDma 2wjA+bVJVok3sMaFmfH7Oy2upFhrSoEOnfNZsO6QG91igKxB1OzifoGUAXArEgyXCUe9 brCw== X-Gm-Message-State: APjAAAXp5HDg5laPyqw7rsi2q8lmgVGkbfG15+JACgIJY1CyFRSGHt33 yQNzctl0hnLJj6YG5/yaGZI8rg== X-Google-Smtp-Source: APXvYqwgyEYZ1f9G6YcS2hIlmZ4ZtPRC3P/H4yYOBzAwxvz5JYD1jZmXNXXZMGrzei5rLzk1LWUI3Q== X-Received: by 2002:a17:90a:ff12:: with SMTP id ce18mr13208040pjb.117.1576195891651; Thu, 12 Dec 2019 16:11:31 -0800 (PST) Received: from dev-psajeepa.dev.purestorage.com ([192.30.188.252]) by smtp.googlemail.com with ESMTPSA id s18sm8081281pfh.47.2019.12.12.16.11.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 12 Dec 2019 16:11:30 -0800 (PST) From: Prabhath Sajeepa To: leon@kernel.org, dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Cc: roland@purestorage.com, psajeepa@purestorage.com Subject: [PATCH] IB/mlx5: Fix outstanding_pi index for GSI qps Date: Thu, 12 Dec 2019 17:11:29 -0700 Message-Id: <1576195889-23527-1-git-send-email-psajeepa@purestorage.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org b0ffeb537f3a changed the way how outstanding WRs are tracked for GSI QP. But the fix did not cover the case when a call to ib_post_send fails and index to track outstanding WRs need to be updated correctly. Fixes: b0ffeb537f3a ('IB/mlx5: Fix iteration overrun in GSI qps ') Signed-off-by: Prabhath Sajeepa --- drivers/infiniband/hw/mlx5/gsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/gsi.c b/drivers/infiniband/hw/mlx5/gsi.c index ac4d8d1..1ae6fd9 100644 --- a/drivers/infiniband/hw/mlx5/gsi.c +++ b/drivers/infiniband/hw/mlx5/gsi.c @@ -507,8 +507,7 @@ int mlx5_ib_gsi_post_send(struct ib_qp *qp, const struct ib_send_wr *wr, ret = ib_post_send(tx_qp, &cur_wr.wr, bad_wr); if (ret) { /* Undo the effect of adding the outstanding wr */ - gsi->outstanding_pi = (gsi->outstanding_pi - 1) % - gsi->cap.max_send_wr; + gsi->outstanding_pi--; goto err; } spin_unlock_irqrestore(&gsi->lock, flags); -- 2.7.4