mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zhengbin <zhengbin13@huawei.com>
To: <gregkh@linuxfoundation.org>, <jslaby@suse.com>,
	<linux-kernel@vger.kernel.org>
Cc: <zhengbin13@huawei.com>
Subject: [PATCH 2/4] tty/serial: kgdb_nmi: use true,false for bool variable
Date: Tue, 24 Dec 2019 17:38:03 +0800	[thread overview]
Message-ID: <1577180285-24904-3-git-send-email-zhengbin13@huawei.com> (raw)
In-Reply-To: <1577180285-24904-1-git-send-email-zhengbin13@huawei.com>

Fixes coccicheck warning:

drivers/tty/serial/kgdb_nmi.c:121:6-13: WARNING: Assignment of 0/1 to bool variable
drivers/tty/serial/kgdb_nmi.c:133:2-9: WARNING: Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/tty/serial/kgdb_nmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/kgdb_nmi.c b/drivers/tty/serial/kgdb_nmi.c
index 4029272..5022447 100644
--- a/drivers/tty/serial/kgdb_nmi.c
+++ b/drivers/tty/serial/kgdb_nmi.c
@@ -118,7 +118,7 @@ static int kgdb_nmi_poll_one_knock(void)
 	int c = -1;
 	const char *magic = kgdb_nmi_magic;
 	size_t m = strlen(magic);
-	bool printch = 0;
+	bool printch = false;

 	c = dbg_io_ops->read_char();
 	if (c == NO_POLL_CHAR)
@@ -130,7 +130,7 @@ static int kgdb_nmi_poll_one_knock(void)
 		n = (n + 1) % m;
 		if (!n)
 			return 1;
-		printch = 1;
+		printch = true;
 	} else {
 		n = 0;
 	}
--
2.7.4


  parent reply	other threads:[~2019-12-24  9:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-24  9:38 [PATCH 0/4] tty: " zhengbin
2019-12-24  9:38 ` [PATCH 1/4] tty: synclink_gt: " zhengbin
2019-12-24  9:38 ` zhengbin [this message]
2019-12-24  9:38 ` [PATCH 3/4] tty/serial: atmel: " zhengbin
2019-12-24  9:38 ` [PATCH 4/4] tty/serial: 8250_exar: " zhengbin
2020-01-11 19:47 ` [PATCH 0/4] tty: " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1577180285-24904-3-git-send-email-zhengbin13@huawei.com \
    --to=zhengbin13@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®