From: David Howells <dhowells@redhat.com>
To: Marc Dionne <marc.dionne@auristor.com>
Cc: dhowells@redhat.com, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-afs@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix use of Don't Fragment flag
Date: Tue, 09 Jan 2024 14:16:17 +0000 [thread overview]
Message-ID: <1577954.1704809777@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAB9dFdteL97Z8GAry9TwmcOfw0+PQDzL_u14PwwAEq5uUHaUkQ@mail.gmail.com>
Marc Dionne <marc.dionne@auristor.com> wrote:
> > +{
> > + if (set)
> > + ip_sock_set_mtu_discover(local->socket->sk, IP_PMTUDISC_DONT);
> > + else
> > + ip_sock_set_mtu_discover(local->socket->sk, IP_PMTUDISC_DO);
> > +}
>
> Shouldn't those be reversed - don't fragment should be IP_PMTUDISC_DO?
Meh. Yes.
> Also, and this is probably already an issue with current code, I don't
> think this is effective if the socket is V6, which it will be in most
> cases.
Hmmm... I guess I should tweak IPV6_MTU_DISCOVER also.
David
prev parent reply other threads:[~2024-01-09 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 10:51 David Howells
2024-01-09 12:59 ` Marc Dionne
2024-01-09 14:16 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1577954.1704809777@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®