From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36881C33CAA for ; Thu, 23 Jan 2020 03:12:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D0972465B for ; Thu, 23 Jan 2020 03:12:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726605AbgAWDMI (ORCPT ); Wed, 22 Jan 2020 22:12:08 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:9236 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725911AbgAWDMI (ORCPT ); Wed, 22 Jan 2020 22:12:08 -0500 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 38780C59AB2450DB0290; Thu, 23 Jan 2020 11:12:05 +0800 (CST) Received: from huawei.com (10.175.105.18) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.439.0; Thu, 23 Jan 2020 11:11:58 +0800 From: linmiaohe To: , , , , , , , , , , CC: , , , Subject: [PATCH] KVM: nVMX: set rflags to specify success in handle_invvpid() default case Date: Thu, 23 Jan 2020 11:14:01 +0800 Message-ID: <1579749241-712-1-git-send-email-linmiaohe@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.105.18] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaohe Lin In handle_invvpid() default case, we just skip emulated instruction and forget to set rflags to specify success. This would result in indefinite rflags value and thus indeterminate return value for guest. Signed-off-by: Miaohe Lin --- Chinese New Year is coming. Happy Spring Festival! ^_^ --- arch/x86/kvm/vmx/nested.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c index 7608924ee8c1..985d3307ec56 100644 --- a/arch/x86/kvm/vmx/nested.c +++ b/arch/x86/kvm/vmx/nested.c @@ -5165,7 +5165,7 @@ static int handle_invvpid(struct kvm_vcpu *vcpu) break; default: WARN_ON_ONCE(1); - return kvm_skip_emulated_instruction(vcpu); + break; } return nested_vmx_succeed(vcpu); -- 2.19.1