From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752548AbdCIHRf (ORCPT ); Thu, 9 Mar 2017 02:17:35 -0500 Received: from fllnx210.ext.ti.com ([198.47.19.17]:42185 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbdCIHRd (ORCPT ); Thu, 9 Mar 2017 02:17:33 -0500 Subject: Re: [PATCH 1/3] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox() To: References: <1487158704-9006-1-git-send-email-rogerq@ti.com> <1487158704-9006-2-git-send-email-rogerq@ti.com> CC: , , , , , "#v4 . 8+" From: Roger Quadros Message-ID: <157a2d6f-1d0a-b9f3-c1ea-cee90877e580@ti.com> Date: Thu, 9 Mar 2017 09:17:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1487158704-9006-2-git-send-email-rogerq@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Felipe, On 15/02/17 13:38, Roger Quadros wrote: > We need to break from all cases if we want to treat > each one of them separately. > > Reported-by: Gustavo A. R. Silva > Fixes: d2728fb3e01f ("usb: dwc3: omap: Pass VBUS and ID events transparently") > Cc: #v4.8+ > Signed-off-by: Roger Quadros Can you please pick this one for v4.11-rc? Thanks. > --- > drivers/usb/dwc3/dwc3-omap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c > index eb1b9cb..35b6351 100644 > --- a/drivers/usb/dwc3/dwc3-omap.c > +++ b/drivers/usb/dwc3/dwc3-omap.c > @@ -250,6 +250,7 @@ static void dwc3_omap_set_mailbox(struct dwc3_omap *omap, > val = dwc3_omap_read_utmi_ctrl(omap); > val |= USBOTGSS_UTMI_OTG_CTRL_IDDIG; > dwc3_omap_write_utmi_ctrl(omap, val); > + break; > > case OMAP_DWC3_VBUS_OFF: > val = dwc3_omap_read_utmi_ctrl(omap); > -- cheers, -roger