From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Andrew Morton <akpm@digeo.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
NFS maillist <nfs@lists.sourceforge.net>
Subject: Re: [PATCH] Convert NFS client to use ->readpages()
Date: Wed, 6 Nov 2002 18:42:10 +0100 [thread overview]
Message-ID: <15817.21618.999074.513995@charged.uio.no> (raw)
In-Reply-To: <3DC8E23A.2578323F@digeo.com>
>>>>> Andrew Morton <akpm@digeo.com> writes:
> Or should it be
> while (!list_empty(...))
Duh. No idea how that crept in.
Concerning your other query: the code is correct as it stands since
nfs_pagein_list() is guaranteed to drain the entire list.
--- linux-2.5.45-02-readpages2/fs/nfs/read.c.orig 2002-11-05 19:45:07.000000000 -0500
+++ linux-2.5.45-02-readpages2/fs/nfs/read.c 2002-11-06 12:35:06.000000000 -0500
@@ -387,7 +387,7 @@
is_sync ? readpage_sync_filler :
readpage_async_filler,
&desc);
- if (!list_empty(pages)) {
+ while (!list_empty(pages)) {
struct page *page = list_entry(pages->prev, struct page, list);
list_del(&page->list);
page_cache_release(page);
prev parent reply other threads:[~2002-11-06 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-06 2:25 Trond Myklebust
2002-11-06 9:34 ` Andrew Morton
2002-11-06 17:42 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15817.21618.999074.513995@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®