From: Mikael Pettersson <mikpe@csd.uu.se>
To: linux-kernel@vger.kernel.org
Subject: [BUG][PATCH] 2.5.46 ide-dma oops on boot
Date: Fri, 8 Nov 2002 11:06:34 +0100 [thread overview]
Message-ID: <15819.36010.413947.840428@kim.it.uu.se> (raw)
I tried 2.5.46 on my News server, and it oopsed on boot in
ide-dma.c:ide_iomio_dma(): the code dereferenced hwif->mate
even though hwif->mate was NULL.
The patch below fixes this issue for me, although this oops
may just be a consequence of some deeper problem.
I suspect this is due to the HW config of the machine in question:
onboard PIIX has nothing on ide0 and a CD-ROM as master on ide1,
the disks are on an add-on Promise Ultra100 card. The oops ocurred
at exactly this point in the boot process:
Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2
ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
PIIX4: IDE controller at PCI slot 00:07.1
PIIX4: chipset revision 1
PIIX4: not 100% native mode: will probe irqs later
ide1: BM-DMA at 0x1868-0x186f, BIOS settings: hdc:DMA, hdd:pio
*************************** here ^
/Mikael
--- linux-2.5.46/drivers/ide/ide-dma.c.~1~ 2002-11-08 09:29:10.000000000 +0100
+++ linux-2.5.46/drivers/ide/ide-dma.c 2002-11-08 10:05:12.000000000 +0100
@@ -926,7 +926,7 @@
request_region(base+16, hwif->cds->extra, hwif->cds->name);
hwif->dma_extra = hwif->cds->extra;
}
- hwif->dma_master = (hwif->channel) ? hwif->mate->dma_base : base;
+ hwif->dma_master = (hwif->channel && hwif->mate) ? hwif->mate->dma_base : base;
if (hwif->dma_base2) {
if (!request_region(hwif->dma_base2, ports, hwif->name))
{
next reply other threads:[~2002-11-08 9:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-08 10:06 Mikael Pettersson [this message]
2002-11-08 16:22 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15819.36010.413947.840428@kim.it.uu.se \
--to=mikpe@csd.uu.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®