From: Sherry Sun <sherry.sun@nxp.com>
To: bp@alien8.de, mchehab@kernel.org, tony.luck@intel.com,
james.morse@arm.com, rrichter@marvell.com,
michal.simek@xilinx.com
Cc: linux-edac@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
frank.li@nxp.com
Subject: [PATCH 1/3] EDAC: synopsys: Remove pinf->col parameter for ZynqMP and i.MX8MP
Date: Mon, 24 Feb 2020 17:42:35 +0800 [thread overview]
Message-ID: <1582537357-10339-2-git-send-email-sherry.sun@nxp.com> (raw)
In-Reply-To: <1582537357-10339-1-git-send-email-sherry.sun@nxp.com>
Since ZynqMP and i.MX8MP platform both call zynqmp_get_error_info()
function to get ce/ue information. In this function, pinf->col parameter
is not used, this parameter is only used by Zynq platforme. So here
pinf->col should not be called and printed for ZynqMP and i.MX8MP.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
drivers/edac/synopsys_edac.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
index 66c801502212..7046b8929522 100644
--- a/drivers/edac/synopsys_edac.c
+++ b/drivers/edac/synopsys_edac.c
@@ -492,8 +492,8 @@ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p)
pinf->bitpos, pinf->data);
} else {
snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
- "DDR ECC error type:%s Row %d Bank %d Col %d ",
- "CE", pinf->row, pinf->bank, pinf->col);
+ "DDR ECC error type:%s Row %d Bank %d ",
+ "CE", pinf->row, pinf->bank);
snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
"BankGroup Number %d Block Number %d ",
pinf->bankgrpnr, pinf->blknr);
@@ -515,8 +515,8 @@ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p)
"UE", pinf->row, pinf->bank, pinf->col);
} else {
snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
- "DDR ECC error type :%s Row %d Bank %d Col %d ",
- "UE", pinf->row, pinf->bank, pinf->col);
+ "DDR ECC error type :%s Row %d Bank %d ",
+ "UE", pinf->row, pinf->bank);
snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
"BankGroup Number %d Block Number %d",
pinf->bankgrpnr, pinf->blknr);
--
2.17.1
next prev parent reply other threads:[~2020-02-24 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 9:42 [PATCH 0/3] Improve the output message for CE/UE Sherry Sun
2020-02-24 9:42 ` Sherry Sun [this message]
2020-02-24 9:42 ` [PATCH 2/3] EDAC: synopsys: Reorganizing " Sherry Sun
2020-02-26 17:49 ` James Morse
2020-02-27 7:09 ` Sherry Sun
2020-02-24 9:42 ` [PATCH 3/3] EDAC: synopsys: Add useful output information for 64 bit systems Sherry Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582537357-10339-2-git-send-email-sherry.sun@nxp.com \
--to=sherry.sun@nxp.com \
--cc=bp@alien8.de \
--cc=frank.li@nxp.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®