From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Kevin Hilman <khilman@linaro.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] PM / Runtime: Add pm_runtime_enable_recursive
Date: Sat, 04 Jul 2015 02:32:19 +0200 [thread overview]
Message-ID: <1582584.Qtpmv8yHCS@vostro.rjw.lan> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1507031102520.23132-100000@netrider.rowland.org>
On Friday, July 03, 2015 11:11:19 AM Alan Stern wrote:
> On Fri, 3 Jul 2015, Tomeu Vizoso wrote:
>
> > >> Yeah, that would remove the need for messing with the runtime PM
> > >> enable status of descendant devices, but I wonder why Rafael went that
> > >> way initially.
> > >
> > > I forget the details. Probably it was just to be safe. We probably
> > > thought that if a device was disabled for runtime PM then its runtime
> > > PM status might not be accurate. But if direct_complete is set then it
> > > may be reasonable to assume that the runtime PM status _is_ accurate.
> >
> > Cool.
>
> > > Rafael and I briefly discussed ignore_children while the original
> > > direct_complete patch was being designed. We didn't come to any
> > > definite conclusion and decided to forget about it for the time being.
> > > Maybe now would be a good time to reconsider it.
> >
> > I would prefer to have ignore_children ignore whether the children of
> > a device were able to do direct_complete, rather than having a
> > direct_complete_default flag (plus not requiring that all its
> > descendants have runtime PM enabled).
>
> Okay, but remember that sometimes these "virtual" devices will exist
> beneath a device that needs to have ignore_children off. So this won't
> be a complete solution to your problem.
>
> Let's see what Rafael thinks about these two issues. It seems to me
> that the hardest part is dealing with drivers/subsystems that have no
> runtime PM support. In such cases, we have to be very careful not to
> use direct_complete unless we know that the device does no power
> management at all.
Precisely.
Thanks,
Rafael
next prev parent reply other threads:[~2015-07-04 0:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 14:11 [PATCH v3 0/2] PM: direct_complete_default and pm_runtime_enable_recursive Tomeu Vizoso
2015-05-19 14:11 ` [PATCH v3 1/2] PM / sleep: Add power.direct_complete_default flag Tomeu Vizoso
2015-05-19 17:50 ` Alan Stern
2015-05-19 20:47 ` Ulf Hansson
2015-05-19 23:38 ` Rafael J. Wysocki
2015-05-19 14:11 ` [PATCH v3 2/2] PM / Runtime: Add pm_runtime_enable_recursive Tomeu Vizoso
2015-05-19 17:49 ` Alan Stern
2015-05-19 23:39 ` Rafael J. Wysocki
2015-05-20 9:03 ` Tomeu Vizoso
2015-05-20 14:24 ` Alan Stern
2015-07-02 13:59 ` Tomeu Vizoso
2015-07-02 15:21 ` Alan Stern
2015-07-03 8:11 ` Tomeu Vizoso
2015-07-03 14:16 ` Alan Stern
2015-07-03 14:22 ` Tomeu Vizoso
2015-07-03 15:11 ` Alan Stern
2015-07-04 0:32 ` Rafael J. Wysocki [this message]
2015-07-04 0:31 ` Rafael J. Wysocki
2015-07-04 14:37 ` Alan Stern
2015-07-05 23:36 ` Rafael J. Wysocki
2015-07-07 0:07 ` Rafael J. Wysocki
2015-07-07 14:55 ` Alan Stern
2015-07-07 22:06 ` Rafael J. Wysocki
2015-07-08 20:31 ` Alan Stern
2015-07-14 13:19 ` Tomeu Vizoso
2015-07-14 21:57 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582584.Qtpmv8yHCS@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=k.kozlowski@samsung.com \
--cc=khilman@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=stern@rowland.harvard.edu \
--cc=tomeu.vizoso@collabora.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®