From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Juan Gomez <juang@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, nfs@lists.sourceforge.net
Subject: Re: Non-blocking lock requests during the grace period
Date: Fri, 15 Nov 2002 18:35:16 +0100 [thread overview]
Message-ID: <15829.12372.977319.366227@helicity.uio.no> (raw)
In-Reply-To: <OF92154664.1C5EF07E-ON87256C72.005A0481@us.ibm.com>
> 2.-I also have this part enclosed in the if(resp->status ==
> NLM_LCK_DENIED_GRACE_PERIOD) as follows:
> if(resp->status == NLM_LCK_DENIED_GRACE_PERIOD) {
> blah blah...
> wait_on_grace:
> if ((proc == NLMPROC_LOCK) &&
> !argp->block)
> return -EAGAIN
> } else {
> ....
> }
> This with the intention to be very specific as to when we want
> the return -EAGAIN to be called.
The above means that you will still block on a F_GETLK query...
In any case, why would we want to return -EAGAIN in one case where
argp->block isn't set, and not in another? If there are cases where we
want to block and where we are not currently setting argp->block (the
only one I can think of might be NLMPROC_UNLOCK), then we should fix
the caller.
Cheers,
Trond
next prev parent reply other threads:[~2002-11-15 17:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-15 16:31 Juan Gomez
2002-11-15 17:35 ` Trond Myklebust [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-11-15 19:09 Juan Gomez
2002-11-15 20:01 ` Trond Myklebust
2002-11-15 18:48 Juan Gomez
2002-11-14 19:56 Juan Gomez
2002-11-15 2:33 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15829.12372.977319.366227@helicity.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=juang@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®