From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B469DC3F2CD for ; Wed, 4 Mar 2020 13:36:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 857DE20870 for ; Wed, 4 Mar 2020 13:36:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="KRMhg3xa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729474AbgCDNgu (ORCPT ); Wed, 4 Mar 2020 08:36:50 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:33090 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728451AbgCDNgu (ORCPT ); Wed, 4 Mar 2020 08:36:50 -0500 Received: by mail-qk1-f195.google.com with SMTP id p62so1584775qkb.0 for ; Wed, 04 Mar 2020 05:36:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=mpYEiYRocka7ATrbRk79a6a7IumZgblHI2WLdpIhwgE=; b=KRMhg3xagLh3UMJC+uZmNRJhAvbb7+lGITFZ6oXEJ30imCsJOA2C8r3Gx1xSeoh0lb u03uyVzA7OaXsX0ecbqGS+TRSALv/m+efBvYRWRK4sQZPqEj/fTrv1B7Pmq325DuD5NW cMufP88PsLaQcCfoDSfv4BPWYvqoVkNYsnhvMkNnX4TuvZd59E+SOYv2wK4k/hxlGpDg A2arqwo0nTy1v+8iaOoMpOA01VAURb/SRsABLzydqTmYAeuDo7DyVz1SfDuQwfpnTmhO X6UJVLROabbZPV6y+CIAT7vCViW9RJcXYUBynLPR36HFNmVikISKGdk38i/5pQf6o5CQ /2HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=mpYEiYRocka7ATrbRk79a6a7IumZgblHI2WLdpIhwgE=; b=Rjuy/1OTjVIjE7OnIWos4PLUqITebJjKmS+4Lz1MgnP+SRs1lwU769KVWcCcgin4lc DtXhc61Yo37asG+olHKPCGfs+zq7efwvFJQXlcEEJd56/jc8Z6LJXsM0iAuWAqRcZYHQ xavX3vNXbOf6aE7wl6FNjnYd3GpiI3HBstckQh8XLjVCKweA/BiOX8TpwsEQgCidYWWf sDptpI2vR9M0MdgZ6gWcnoUN9U6TYxncHqH4oJnFA7UNAbmpwkKPSLgJcDF6J7aVLyGB mpL9aP6zPivJqLFAEHok+xWBUlD1+uvfDUafh6XcQ08ZVMaN2xyh+w2tprjPh/mMjZXZ TvbA== X-Gm-Message-State: ANhLgQ1/rRxB/eS/d1lQtG64dEetl5vxu5XYlNaGbJA1Z/Zu72DASw2t qxno80cFoF8zaETGwbb62siszA== X-Google-Smtp-Source: ADFU+vvwqhWeKWuvP/JFbgNL86TeSCyI6fdLqE6IggaPG4339qKIgUrS9GlI8K+DfcRdgWhhjUKT7Q== X-Received: by 2002:a05:620a:2224:: with SMTP id n4mr2787662qkh.21.1583329009507; Wed, 04 Mar 2020 05:36:49 -0800 (PST) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id k5sm1492991qte.25.2020.03.04.05.36.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2020 05:36:48 -0800 (PST) Message-ID: <1583329007.7365.151.camel@lca.pw> Subject: Re: [PATCH] cgroup: fix psi_show() crash on 32bit ino archs From: Qian Cai To: Johannes Weiner Cc: tj@kernel.org, lizefan@huawei.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 04 Mar 2020 08:36:47 -0500 In-Reply-To: <20200224162906.GB1674@cmpxchg.org> References: <20200224030007.3990-1-cai@lca.pw> <20200224162906.GB1674@cmpxchg.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-02-24 at 11:29 -0500, Johannes Weiner wrote: > On Sun, Feb 23, 2020 at 10:00:07PM -0500, Qian Cai wrote: > > Similar to the commit d7495343228f ("cgroup: fix incorrect > > WARN_ON_ONCE() in cgroup_setup_root()"), cgroup_id(root_cgrp) does not > > equal to 1 on 32bit ino archs which triggers all sorts of issues with > > psi_show() on s390x. For example, > > > > BUG: KASAN: slab-out-of-bounds in collect_percpu_times+0x2d0/ > > Read of size 4 at addr 000000001e0ce000 by task read_all/3667 > > collect_percpu_times+0x2d0/0x798 > > psi_show+0x7c/0x2a8 > > seq_read+0x2ac/0x830 > > vfs_read+0x92/0x150 > > ksys_read+0xe2/0x188 > > system_call+0xd8/0x2b4 > > > > Fix it by using cgroup_ino(). > > > > Fixes: 743210386c03 ("cgroup: use cgrp->kn->id as the cgroup ID") > > Signed-off-by: Qian Cai > > Acked-by: Johannes Weiner Tejun, can you take a look at this when you had a chance?