From: Huazhong Tan <tanhuazhong@huawei.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<salil.mehta@huawei.com>, <yisen.zhuang@huawei.com>,
<linuxarm@huawei.com>, <kuba@kernel.org>,
Yufeng Mo <moyufeng@huawei.com>,
Huazhong Tan <tanhuazhong@huawei.com>
Subject: [PATCH net-next 3/9] net: hns3: remove an unnecessary resetting check in hclge_handle_hw_ras_error()
Date: Fri, 6 Mar 2020 10:57:12 +0800 [thread overview]
Message-ID: <1583463438-60953-4-git-send-email-tanhuazhong@huawei.com> (raw)
In-Reply-To: <1583463438-60953-1-git-send-email-tanhuazhong@huawei.com>
From: Yufeng Mo <moyufeng@huawei.com>
In hclge_handle_hw_ras_error(), it is unnecessary to check
HCLGE_STATE_RST_HANDLING flag, because the reset priority
has been ensured by the process itself.
Signed-off-by: Yufeng Mo <moyufeng@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c
index c85b72d..50d5ef7 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c
@@ -1667,9 +1667,6 @@ pci_ers_result_t hclge_handle_hw_ras_error(struct hnae3_ae_dev *ae_dev)
hclge_handle_rocee_ras_error(ae_dev);
}
- if (test_bit(HCLGE_STATE_RST_HANDLING, &hdev->state))
- goto out;
-
if (ae_dev->hw_err_reset_req)
return PCI_ERS_RESULT_NEED_RESET;
--
2.7.4
next prev parent reply other threads:[~2020-03-06 2:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 2:57 [PATCH net-next 0/9] net: hns3: misc updates for -net-next Huazhong Tan
2020-03-06 2:57 ` [PATCH net-next 1/9] net: hns3: fix some mixed type assignment Huazhong Tan
2020-03-06 3:39 ` shenjian (K)
2020-03-06 6:18 ` tanhuazhong
2020-03-06 2:57 ` [PATCH net-next 2/9] net: hns3: rename macro HCLGE_MAX_NCL_CONFIG_LENGTH Huazhong Tan
2020-03-06 2:57 ` Huazhong Tan [this message]
2020-03-06 2:57 ` [PATCH net-next 4/9] net: hns3: delete some reduandant code Huazhong Tan
2020-03-06 2:57 ` [PATCH net-next 5/9] net: hns3: add a check before PF inform VF to reset Huazhong Tan
2020-03-06 2:57 ` [PATCH net-next 6/9] net: hns3: print out status register when VF receives unknown source interrupt Huazhong Tan
2020-03-06 2:57 ` [PATCH net-next 7/9] net: hns3: print out command code when dump fails in debugfs Huazhong Tan
2020-03-06 2:57 ` [PATCH net-next 8/9] net: hns3: synchronize some print relating to reset issue Huazhong Tan
2020-03-06 2:57 ` [PATCH net-next 9/9] net: hns3: delete unnecessary logs after kzalloc fails Huazhong Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1583463438-60953-4-git-send-email-tanhuazhong@huawei.com \
--to=tanhuazhong@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=moyufeng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®