From: Leo Yuriev <leo@yuriev.ru>
To: linux-kernel@vger.kernel.org
Subject: Re[2]: [leo@yuriev.ru: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header]
Date: Thu, 10 Mar 2005 17:13:30 +0300 [thread overview]
Message-ID: <1583531652.20050310171330@yuriev.ru> (raw)
[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]
>>From looking at the patch:
j> ------
j> + /*
j> + * We map VLAN_TCI priority (0..7) to skb->priority (0..15)
j> + * most similarly e.g. 0->0, 1->1, .., 7->7
j> + */
j> + skb->priority = (vlan_TCI >> 13) & 7;
j> ------
j> This is wrong. IEEE priorities are opposite of IETF priorities (as used by
skb->>prio).
j> Unless you install a prio qdisc and rewrite the priomap, you are screwed.
j> So you should do opposite mapping, i.e something along the lines of
j> VLAN_TCI priority (0..7) to skb->priority (15..8) i,e skb->priority = 15 - vlan_TCI;
j> cheers,
j> jamal
Jamal, you are wrong!
802.1p defines priority as "linear" from 0 to 7,
the 0 is lowest priority and 7 is highest.
couple FoC links:
http://www.linktionary.com/q/qos.html
http://www.nwfusion.com/details/475.html
--
С уважением,
Leo mailto:leo@yuriev.ru
-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: 2.6
mQCPA0HMImkBbQEEALnWXpnchl1dHaCfwnXe2RO8ft9e7K5IGRW1lE9RERMy6R3L
JnMXMPiuWm/4tx6H/yTRUML8LbuACzf2Np9oHTxbDWxP40wGxQKrPDlzv/9gLEp6
ZwGF8mSfvZrPHux1LwIbryQxjlmwfNCkE+qiVOBWMsD7yAFCWrZztbWTWJ6pABEB
AAG0GkxlbyBZdXJpZXYgPGxlb0B5dXJpZXYucnU+iQCVAwUQQcwiabZztbWTWJ6p
AQG6cAP9H0O+MMa0WDlGE2JGG+SWuu9Iuqg76Hp6tjtrz2pLWEzbq8oqCkE0THff
/YUUaKqnrLELwEaptE+MrWSv9Zt1K/PauMpKUWXhlYqGcGB2NqJL69AONQte0M4B
rPSSts4CU7gK2Zuds1DOLiON7e9Sbpjc5T+4D7Jw5XGKMz66nhY=
=qGIk
-----END PGP PUBLIC KEY BLOCK-----
[-- Attachment #2: Type: application/pgp-signature, Size: 282 bytes --]
reply other threads:[~2005-03-10 14:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1583531652.20050310171330@yuriev.ru \
--to=leo@yuriev.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®