mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Vincenzo Frascino" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, x86 <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [tip: timers/core] arm64: vdso32: Code clean up
Date: Sat, 21 Mar 2020 14:33:26 -0000	[thread overview]
Message-ID: <158480120655.28353.3034580466720093310.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20200317122220.30393-19-vincenzo.frascino@arm.com>

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     94d0f5be885ce1e6ca2886af1543165c16745d13
Gitweb:        https://git.kernel.org/tip/94d0f5be885ce1e6ca2886af1543165c16745d13
Author:        Vincenzo Frascino <vincenzo.frascino@arm.com>
AuthorDate:    Fri, 20 Mar 2020 14:53:43 
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Sat, 21 Mar 2020 15:24:00 +01:00

arm64: vdso32: Code clean up

The compat vdso library had some checks that are not anymore relevant.

Remove the unused code from the compat vDSO library.

Note: This patch is preparatory for a future one that will introduce
asm/vdso/processor.h on arm64.

Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/lkml/20200317122220.30393-19-vincenzo.frascino@arm.com
Link: https://lkml.kernel.org/r/20200320145351.32292-19-vincenzo.frascino@arm.com

---
 arch/arm64/include/asm/vdso/compat_gettimeofday.h |  8 --------
 arch/arm64/kernel/vdso32/vgettimeofday.c          | 12 ------------
 2 files changed, 20 deletions(-)

diff --git a/arch/arm64/include/asm/vdso/compat_gettimeofday.h b/arch/arm64/include/asm/vdso/compat_gettimeofday.h
index 81b0c39..401df2b 100644
--- a/arch/arm64/include/asm/vdso/compat_gettimeofday.h
+++ b/arch/arm64/include/asm/vdso/compat_gettimeofday.h
@@ -76,10 +76,6 @@ int clock_getres_fallback(clockid_t _clkid, struct __kernel_timespec *_ts)
 	register long ret asm ("r0");
 	register long nr asm("r7") = __NR_compat_clock_getres_time64;
 
-	/* The checks below are required for ABI consistency with arm */
-	if ((_clkid >= MAX_CLOCKS) && (_ts == NULL))
-		return -EINVAL;
-
 	asm volatile(
 	"       swi #0\n"
 	: "=r" (ret)
@@ -97,10 +93,6 @@ int clock_getres32_fallback(clockid_t _clkid, struct old_timespec32 *_ts)
 	register long ret asm ("r0");
 	register long nr asm("r7") = __NR_compat_clock_getres;
 
-	/* The checks below are required for ABI consistency with arm */
-	if ((_clkid >= MAX_CLOCKS) && (_ts == NULL))
-		return -EINVAL;
-
 	asm volatile(
 	"       swi #0\n"
 	: "=r" (ret)
diff --git a/arch/arm64/kernel/vdso32/vgettimeofday.c b/arch/arm64/kernel/vdso32/vgettimeofday.c
index 54fc1c2..ddbad47 100644
--- a/arch/arm64/kernel/vdso32/vgettimeofday.c
+++ b/arch/arm64/kernel/vdso32/vgettimeofday.c
@@ -11,20 +11,12 @@
 int __vdso_clock_gettime(clockid_t clock,
 			 struct old_timespec32 *ts)
 {
-	/* The checks below are required for ABI consistency with arm */
-	if ((u32)ts >= TASK_SIZE_32)
-		return -EFAULT;
-
 	return __cvdso_clock_gettime32(clock, ts);
 }
 
 int __vdso_clock_gettime64(clockid_t clock,
 			   struct __kernel_timespec *ts)
 {
-	/* The checks below are required for ABI consistency with arm */
-	if ((u32)ts >= TASK_SIZE_32)
-		return -EFAULT;
-
 	return __cvdso_clock_gettime(clock, ts);
 }
 
@@ -37,10 +29,6 @@ int __vdso_gettimeofday(struct __kernel_old_timeval *tv,
 int __vdso_clock_getres(clockid_t clock_id,
 			struct old_timespec32 *res)
 {
-	/* The checks below are required for ABI consistency with arm */
-	if ((u32)res >= TASK_SIZE_32)
-		return -EFAULT;
-
 	return __cvdso_clock_getres_time32(clock_id, res);
 }
 

  parent reply	other threads:[~2020-03-21 14:34 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-17 12:21 [PATCH v4 00/26] Introduce common headers for vDSO Vincenzo Frascino
2020-03-17 12:21 ` [PATCH v4 01/26] linux/const.h: Extract common header " Vincenzo Frascino
2020-03-17 12:21 ` [PATCH v4 02/26] linux/bits.h: " Vincenzo Frascino
2020-03-17 12:21 ` [PATCH v4 03/26] linux/limits.h: " Vincenzo Frascino
2020-03-17 12:21 ` [PATCH v4 04/26] x86:Introduce asm/vdso/clocksource.h Vincenzo Frascino
2020-03-17 12:21 ` [PATCH v4 05/26] arm: Introduce asm/vdso/clocksource.h Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 06/26] arm64: " Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 07/26] mips: " Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 08/26] linux/clocksource.h: Extract common header for vDSO Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 09/26] linux/math64.h: " Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 10/26] linux/time.h: " Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 11/26] linux/time32.h: " Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 12/26] linux/time64.h: " Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 13/26] linux/jiffies.h: " Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 14/26] linux/ktime.h: " Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 15/26] common: Introduce processor.h Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 16/26] scripts: Fix the inclusion order in modpost Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 17/26] linux/elfnote.h: Replace elf.h with UAPI equivalent Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 18/26] arm64: vdso32: Replace TASK_SIZE_32 check in vgettimeofday Vincenzo Frascino
2020-03-17 14:38   ` Catalin Marinas
2020-03-17 15:04     ` Vincenzo Frascino
2020-03-17 15:50       ` Catalin Marinas
2020-03-17 16:40         ` Vincenzo Frascino
2020-03-17 16:43           ` Vincenzo Frascino
2020-03-17 17:48           ` Catalin Marinas
2020-03-18 16:14             ` Vincenzo Frascino
2020-03-18 18:36               ` Catalin Marinas
2020-03-19 12:38                 ` Vincenzo Frascino
2020-03-19 18:10                   ` Catalin Marinas
2020-03-20 13:05                     ` Vincenzo Frascino
2020-03-20 14:22                       ` Catalin Marinas
2020-03-20 14:41                         ` Vincenzo Frascino
2020-03-19 15:49     ` Andy Lutomirski
2020-03-19 16:58       ` Vincenzo Frascino
2020-03-19 18:32         ` Will Deacon
2020-03-21 14:33   ` tip-bot2 for Vincenzo Frascino [this message]
2020-03-17 12:22 ` [PATCH v4 19/26] arm64: Introduce asm/vdso/processor.h Vincenzo Frascino
2020-03-17 17:52   ` Catalin Marinas
2020-03-17 12:22 ` [PATCH v4 20/26] arm64: vdso: Include common headers in the vdso library Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 21/26] arm64: vdso32: " Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 22/26] mips: vdso: Enable mips to use common headers Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 23/26] x86: vdso: Enable x86 " Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 24/26] arm: vdso: Enable arm " Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 25/26] lib: vdso: Enable " Vincenzo Frascino
2020-03-17 12:22 ` [PATCH v4 26/26] arm64: vdso32: Enable Clang Compilation Vincenzo Frascino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=158480120655.28353.3034580466720093310.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vincenzo.frascino@arm.com \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®