From: "tip-bot2 for Anshuman Khandual" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
Borislav Petkov <bp@suse.de>, Baoquan He <bhe@redhat.com>,
Balbir Singh <bsingharora@gmail.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
x86 <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [tip: x86/cleanups] x86/mm: Drop pud_mknotpresent()
Date: Mon, 23 Mar 2020 08:46:42 -0000 [thread overview]
Message-ID: <158495320286.28353.18108219786340349995.tip-bot2@tip-bot2> (raw)
In-Reply-To: <1584925542-13034-1-git-send-email-anshuman.khandual@arm.com>
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: 31a9122058bc5f042cb04bcdb8cd9e6c77fdae8d
Gitweb: https://git.kernel.org/tip/31a9122058bc5f042cb04bcdb8cd9e6c77fdae8d
Author: Anshuman Khandual <anshuman.khandual@arm.com>
AuthorDate: Mon, 23 Mar 2020 06:35:42 +05:30
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Mon, 23 Mar 2020 09:11:48 +01:00
x86/mm: Drop pud_mknotpresent()
There is an inconsistency between PMD and PUD-based THP page table helpers
like the following, as pud_present() does not test for _PAGE_PSE.
pmd_present(pmd_mknotpresent(pmd)) : True
pud_present(pud_mknotpresent(pud)) : False
Drop pud_mknotpresent() as there are no current users. If/when needed
back later, pud_present() will also have to be fixed to accommodate
_PAGE_PSE.
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Baoquan He <bhe@redhat.com>
Acked-by: Balbir Singh <bsingharora@gmail.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Link: https://lkml.kernel.org/r/1584925542-13034-1-git-send-email-anshuman.khandual@arm.com
---
arch/x86/include/asm/pgtable.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h
index 7e11866..d74dc56 100644
--- a/arch/x86/include/asm/pgtable.h
+++ b/arch/x86/include/asm/pgtable.h
@@ -595,12 +595,6 @@ static inline pmd_t pmd_mknotpresent(pmd_t pmd)
__pgprot(pmd_flags(pmd) & ~(_PAGE_PRESENT|_PAGE_PROTNONE)));
}
-static inline pud_t pud_mknotpresent(pud_t pud)
-{
- return pfn_pud(pud_pfn(pud),
- __pgprot(pud_flags(pud) & ~(_PAGE_PRESENT|_PAGE_PROTNONE)));
-}
-
static inline u64 flip_protnone_guard(u64 oldval, u64 val, u64 mask);
static inline pte_t pte_modify(pte_t pte, pgprot_t newprot)
next prev parent reply other threads:[~2020-03-23 8:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 1:05 [PATCH] x86/memory: " Anshuman Khandual
2020-03-23 1:37 ` Baoquan He
2020-03-23 3:25 ` Balbir Singh
2020-03-23 7:47 ` Kirill A. Shutemov
2020-03-23 8:46 ` tip-bot2 for Anshuman Khandual [this message]
2020-03-23 20:29 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158495320286.28353.18108219786340349995.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=anshuman.khandual@arm.com \
--cc=bhe@redhat.com \
--cc=bp@suse.de \
--cc=bsingharora@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®