From: John Garry <john.garry@huawei.com>
To: <xuwei5@huawei.com>, <arnd@arndb.de>
Cc: <okaya@kernel.org>, <bhelgaas@google.com>,
<linux-kernel@vger.kernel.org>, <linux-arch@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <linuxarm@huawei.com>,
<olof@lixom.net>, <jiaxun.yang@flygoat.com>,
"John Garry" <john.garry@huawei.com>
Subject: [PATCH v2 0/3] io.h, logic_pio: Allow barriers for inX() and outX() be overridden
Date: Sat, 28 Mar 2020 00:06:11 +0800 [thread overview]
Message-ID: <1585325174-195915-1-git-send-email-john.garry@huawei.com> (raw)
Since commits a7851aa54c0c ("io: change outX() to have their own IO
barrier overrides") and 87fe2d543f81 ("io: change inX() to have their own
IO barrier overrides"), the outX() and inX() functions have memory
barriers which can be overridden per-arch.
However, under CONFIG_INDIRECT_PIO, logic_pio defines its own version of
inX() and outX(), which still use readb et al. For these, the barrier
after a raw read is weaker than it otherwise would be.
This series generates consistent behaviour for logic_pio, by defining
generic _inX() and _outX() in asm-generic/io.h, and using those in
logic_pio. Generic _inX() and _outX() have per-arch overrideable
barriers.
The topic was discussed there originally:
https://lore.kernel.org/lkml/2e80d7bc-32a0-cc40-00a9-8a383a1966c2@huawei.com/
A small tidy-up patch is included.
I hope that series can go through the arm-soc tree, as with other recent
logic_pio changes.
Hi Arnd,
I added your tag, but please let me know if you have any issue with the
updated change in patch #1.
cheers
- Differences to v1
- fix x86 clang build by adding extra build swicth for _{in,out}X
- added Arnd's RB tag
John Garry (3):
io: Provide _inX() and _outX()
logic_pio: Improve macro argument name
logic_pio: Use _inX() and _outX()
include/asm-generic/io.h | 64 +++++++++++++++++++++++++++++++++---------------
lib/logic_pio.c | 22 ++++++++---------
2 files changed, 55 insertions(+), 31 deletions(-)
--
2.16.4
next reply other threads:[~2020-03-27 16:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 16:06 John Garry [this message]
2020-03-27 16:06 ` [PATCH v2 1/3] io: Provide _inX() and _outX() John Garry
2020-03-27 16:06 ` [PATCH v2 2/3] logic_pio: Improve macro argument name John Garry
2020-03-27 16:06 ` [PATCH v2 3/3] logic_pio: Use _inX() and _outX() John Garry
2020-05-15 7:07 ` [PATCH v2 0/3] io.h, logic_pio: Allow barriers for inX() and outX() be overridden Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1585325174-195915-1-git-send-email-john.garry@huawei.com \
--to=john.garry@huawei.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=okaya@kernel.org \
--cc=olof@lixom.net \
--cc=xuwei5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®