mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: <rjw@rjwysocki.net>, <lenb@kernel.org>
Cc: <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<sudeep.holla@arm.com>, <jeremy.linton@arm.com>,
	<linuxarm@huawei.com>, <wanghuiqiang@huawei.com>,
	John Garry <john.garry@huawei.com>
Subject: [PATCH] ACPI: PPTT: Inform user that table offset used for Physical processor node ID
Date: Thu, 2 Apr 2020 20:22:25 +0800	[thread overview]
Message-ID: <1585830145-208714-1-git-send-email-john.garry@huawei.com> (raw)

If the the Processor ID valid is not set for a Physical Processor Package
node, then the node table offset is used as a substitute. As such, we
may get info like this from sysfs:

root@(none)$ pwd
/sys/devices/system/cpu/cpu0/topology
root@(none)$ more physical_package_id
56

Inform the user of this in the bootlog, as it is much less than ideal, and
they can remedy this in their FW.

This topic was originally discussed in:
https://lore.kernel.org/linux-acpi/c325cfe2-7dbf-e341-7f0f-081b6545e890@huawei.com/T/#m0ec18637d8586f832084a8a6af22580e6174669a

Signed-off-by: John Garry <john.garry@huawei.com>

diff --git a/drivers/acpi/pptt.c b/drivers/acpi/pptt.c
index 4ae93350b70d..b4ed3c818e00 100644
--- a/drivers/acpi/pptt.c
+++ b/drivers/acpi/pptt.c
@@ -515,6 +515,8 @@ static int topology_get_acpi_cpu_tag(struct acpi_table_header *table,
 		if (level == 0 ||
 		    cpu_node->flags & ACPI_PPTT_ACPI_PROCESSOR_ID_VALID)
 			return cpu_node->acpi_processor_id;
+		if (level == PPTT_ABORT_PACKAGE)
+			pr_notice_once("Physical package node Processor ID valid not set, will use table offset as substitute\n");
 		return ACPI_PTR_DIFF(cpu_node, table);
 	}
 	pr_warn_once("PPTT table found, but unable to locate core %d (%d)\n",
-- 
2.16.4


             reply	other threads:[~2020-04-02 12:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02 12:22 John Garry [this message]
2020-04-02 13:08 ` Sudeep Holla
2020-04-02 13:17   ` John Garry
2020-04-02 13:24 ` Hanjun Guo
2020-04-02 13:55 ` Jeremy Linton
2020-04-02 14:51   ` John Garry
2020-04-02 14:54     ` Jeremy Linton
  -- strict thread matches above, loose matches on Subject: below --
2020-04-02 10:59 John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1585830145-208714-1-git-send-email-john.garry@huawei.com \
    --to=john.garry@huawei.com \
    --cc=jeremy.linton@arm.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=rjw@rjwysocki.net \
    --cc=sudeep.holla@arm.com \
    --cc=wanghuiqiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®