From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034719AbcIWNqK (ORCPT ); Fri, 23 Sep 2016 09:46:10 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:56286 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034504AbcIWNqD (ORCPT ); Fri, 23 Sep 2016 09:46:03 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: lgirdwood@gmail.com, broonie@kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH 2/2] regulator: dbx500: add missing header dependencies Date: Fri, 23 Sep 2016 15:45:50 +0200 Message-ID: <15875973.XhzGpPx04t@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1474635010-4993-1-git-send-email-baoyou.xie@linaro.org> References: <1474635010-4993-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:s5VVwdnkecIyt5EsSx5jjlKSxF5O+y0iLRKrQwqO+JBVuTJLhQh K2qsNQ00IO6H18GZDFj9XK8dW2N5zpbE8j5kRUWSkTNHf7JDvURHMGbOT5JTEwZB3OsRBbP VzqnsZsIyziIpvmM8+nsWsosc1kAR1LBa2yfmiIoNWl/Tf5L/1Dm7v6hX6PCtU6BUQvIUpX y6BH6iGsLNUWgKUASZ8yQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:JjLHB4n1LQo=:Q0VrPaEq/xjH3WzPqAPFOG 7aRfZPwvrJAwbJZ6HagcuK82v5v78FEGhCkt2Cl3araPautBXmZoBHAnfZLRLO6mhA6gbjp+2 KAAY+9oxFKTM/L3ZLovolsiRqeVbVeqXWWeJbiClsGTh8AgYwfmJmfeM3EthEIOakm+33JkoY fTB0oIV17Yn3Q238xwe1w9JGTxMD5sZPqmLGd7u03Se3LT9XVf0RLK8BU0zCZi5yRomj2toAn mIoqAn7Tuxr5sJqF6PgVYzs5SavtMbgIzQGfuDAEBxbAelZmvSi1C93MF7w4KGAWW+mkZRAFI CTldnV4I3Nowk+XYnS29peEmIwTpJn7S0b8YST2O4yr9LnaAMuqcZs4JmZs3z4WabbX0OVdwZ DKJy4y1G8QtjkF7CyPjwyXc5c18RRORZsPP1GmRk+Cxrbj6s0jCY2FAUetpqw8KzNJI0v1PtM 8FuMYsgiySuIQ+NOzwjKYoFxVX3X7cXNGMiMMXPLr+ovTCPsELZ9Y02xGzx5fJ5ihIfHYi9ya u9USP7N0473Q3m/MTGOKTZIfxdm+qvuF4hkdOCIaAjMCVpNSiRCbBys+Zti8/AgesHS0EO50n OOfpUYjEuxkl2Bu56kKD8pl5EIHYX0OyXHvfpSm8o1zMoHO2arW0IliVwGowTd78ZWpKb0F2w VbPk6tTD/ohB9pZC7l+CftYztx5qYVqFWwaDB09aL6xMhYA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, September 23, 2016 8:50:10 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/regulator/dbx500-prcmu.c:158:27: warning: no previous prototype for 'dbx500_regulator_testcase' [-Wmissing-prototypes] > > In fact, this function is not declared in any file, but should be > declared in a header file. thus can be recognized in other file. > > So this patch adds the declaration into > drivers/regulator/dbx500-prcmu.h. > > Signed-off-by: Baoyou Xie > I'm always suspicious of a patch that only adds a declaration, as that tends to mean that no other caller ever existed. In this case, there is an empty "__weak" function definition and it is called from the driver itself, but there is no other non-weak definition. If there was another definition, it would probably be wrong, so I'd just remove the function completely and not call it. Arnd