From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A7E9C47247 for ; Tue, 5 May 2020 16:13:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2698E20836 for ; Tue, 5 May 2020 16:13:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588695237; bh=dpXPFwKuVMrPa7413QY+1yJ7/pkzBpNiSnMEv+1die4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YhDfCqv3YFA6DGm/PzmQgMf/zNmzQUYeKVduPkIaiBlhQdq99hjA+jsGn280xTGgp MYIELH8xMuzJnHsNKAim+xReYudaXr94DiAHBce9zD0sZW5ldTRtfnb09Wed209Uvp PlgsMJwc5l3wZaV63m36sB+gfUL2HiJmaauvNfFo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730666AbgEEQN4 (ORCPT ); Tue, 5 May 2020 12:13:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:59430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728807AbgEEQNv (ORCPT ); Tue, 5 May 2020 12:13:51 -0400 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 75F6D206A4; Tue, 5 May 2020 16:13:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588695230; bh=dpXPFwKuVMrPa7413QY+1yJ7/pkzBpNiSnMEv+1die4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YMruXtbwRLDiFtaSuq49ZBOGAUPM520/Z9wz5f24Zvyj55NVRs57wCT7bIIr9epPJ MN6iiyCoC+MWBt+bCoJImrZ5O06KJ9UN5+NBbB+5xYeQ0a2RtMSXZUCXHXGNrYM+Im QUSZiMN0CryEfhf6eFAFwD5DGN046UE6m+oBJFlI= From: Will Deacon To: Daniel Thompson , Catalin Marinas Cc: Will Deacon , linux-kernel@vger.kernel.org, patches@linaro.org, Douglas Anderson , linux-arm-kernel@lists.infradead.org, Jason Wessel Subject: Re: [PATCH v2] arm64: cacheflush: Fix KGDB trap detection Date: Tue, 5 May 2020 17:13:45 +0100 Message-Id: <158869137087.244424.4260224460496540281.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200504170518.2959478-1-daniel.thompson@linaro.org> References: <20200504170518.2959478-1-daniel.thompson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 4 May 2020 18:05:18 +0100, Daniel Thompson wrote: > flush_icache_range() contains a bodge to avoid issuing IPIs when the kgdb > trap handler is running because issuing IPIs is unsafe (and not needed) > in this execution context. However the current test, based on > kgdb_connected is flawed: it both over-matches and under-matches. > > The over match occurs because kgdb_connected is set when gdb attaches > to the stub and remains set during normal running. This is relatively > harmelss because in almost all cases irq_disabled() will be false. > > [...] Applied to arm64 (for-next/misc), thanks! [1/1] arm64: cacheflush: Fix KGDB trap detection https://git.kernel.org/arm64/c/ab8ad279ceac Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev