From: Maninder Singh <maninder1.s@samsung.com>
To: yamada.masahiro@socionext.com, george_davis@mentor.com
Cc: linux-kernel@vger.kernel.org, a.sahrawat@samsung.com,
arnd@arndb.de, ak@linux.intel.com,
Maninder Singh <maninder1.s@samsung.com>,
Vaneet Narang <v.narang@samsung.com>
Subject: [PATCH v2 3/4] scripts/checkstack.pl: add arm push handling for stack usage
Date: Fri, 8 May 2020 16:33:16 +0530 [thread overview]
Message-ID: <1588935797-7283-3-git-send-email-maninder1.s@samsung.com> (raw)
In-Reply-To: <1588935797-7283-1-git-send-email-maninder1.s@samsung.com>
To count stack usage of push {*, fp, ip, lr, pc} instruction in ARM,
if FRAME POINTER is enabled.
e.g. c01f0d48: e92ddff0 push {r4, r5, r6, r7, r8, r9, sl, fp, ip, lr, pc}
c01f0d50 <Y>:
c01f0d44: e1a0c00d mov ip, sp
c01f0d48: e92ddff0 push {r4, r5, r6, r7, r8, r9, sl, fp, ip, lr, pc}
c01f0d4c: e24cb004 sub fp, ip, #4
c01f0d50: e24dd094 sub sp, sp, #448 ; 0x1C0
$ cat dump | scripts/checkstack.pl arm
0xc01f0d50 Y []: 448
added subroutine frame work for this.
After change:
0xc01f0d500 Y []: 492
Co-developed-by: Vaneet Narang <v.narang@samsung.com>
Signed-off-by: Vaneet Narang <v.narang@samsung.com>
Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
---
scripts/checkstack.pl | 28 +++++++++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/scripts/checkstack.pl b/scripts/checkstack.pl
index bc23cc7..bc07e19 100755
--- a/scripts/checkstack.pl
+++ b/scripts/checkstack.pl
@@ -34,8 +34,10 @@ use strict;
# $& (whole re) matches the complete objdump line with the stack growth
# $1 (first bracket) matches the dynamic amount of the stack growth
#
+# $sub: subroutine for special handling to check stack usage.
+#
# use anything else and feel the pain ;)
-my (@stack, $re, $dre, $x, $xs, $funcre, $min_stack);
+my (@stack, $re, $dre, $sub, $x, $xs, $funcre, $min_stack);
{
my $arch = shift;
if ($arch eq "") {
@@ -59,6 +61,7 @@ my (@stack, $re, $dre, $x, $xs, $funcre, $min_stack);
} elsif ($arch eq 'arm') {
#c0008ffc: e24dd064 sub sp, sp, #100 ; 0x64
$re = qr/.*sub.*sp, sp, #(([0-9]{2}|[3-9])[0-9]{2})/o;
+ $sub = \&arm_push_handling;
} elsif ($arch =~ /^x86(_64)?$/ || $arch =~ /^i[3456]86$/) {
#c0105234: 81 ec ac 05 00 00 sub $0x5ac,%esp
# or
@@ -112,6 +115,24 @@ my (@stack, $re, $dre, $x, $xs, $funcre, $min_stack);
}
#
+# To count stack usage of push {*, fp, ip, lr, pc} instruction in ARM,
+# if FRAME POINTER is enabled.
+# e.g. c01f0d48: e92ddff0 push {r4, r5, r6, r7, r8, r9, sl, fp, ip, lr, pc}
+#
+sub arm_push_handling {
+ my $regex = qr/.*push.*fp, ip, lr, pc}/o;
+ my $size = 0;
+ my $line_arg = shift;
+
+ if ($line_arg =~ m/$regex/) {
+ $size = $line_arg =~ tr/,//;
+ $size = ($size + 1) * 4;
+ }
+
+ return $size;
+}
+
+#
# main()
#
my ($func, $file, $lastslash, $total_size, $addr, $intro);
@@ -166,6 +187,11 @@ while (my $line = <STDIN>) {
$size = hex($size) if ($size =~ /^0x/);
$total_size += $size;
}
+ elsif (defined $sub) {
+ my $size = &$sub($line);
+
+ $total_size += $size;
+ }
}
if ($total_size > $min_stack) {
push @stack, "$intro$total_size\n";
--
1.9.1
next prev parent reply other threads:[~2020-05-08 11:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200508110343epcas5p1ae3398e56ee895572487d05b730bd466@epcas5p1.samsung.com>
2020-05-08 11:03 ` [PATCH v2 1/4] scripts/checkstack.pl: don't display $dre as different entity Maninder Singh
[not found] ` <CGME20200508110351epcas5p32b6adff3dd1cb36dd4912c82bb291bbd@epcas5p3.samsung.com>
2020-05-08 11:03 ` [PATCH v2 2/4] scripts/checkstack.pl: Add argument to print stacks greather than value Maninder Singh
[not found] ` <CGME20200508110354epcas5p3b80625f7ae03836a38547017b671268d@epcas5p3.samsung.com>
2020-05-08 11:03 ` Maninder Singh [this message]
[not found] ` <CGME20200508110359epcas5p19f9e7bdbd7a9c2880308f5201f6badc9@epcas5p1.samsung.com>
2020-05-08 11:03 ` [PATCH v2 4/4] scripts/checkstack.pl: fix arm sp regex Maninder Singh
2020-05-09 7:42 ` [PATCH v2 1/4] scripts/checkstack.pl: don't display $dre as different entity Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1588935797-7283-3-git-send-email-maninder1.s@samsung.com \
--to=maninder1.s@samsung.com \
--cc=a.sahrawat@samsung.com \
--cc=ak@linux.intel.com \
--cc=arnd@arndb.de \
--cc=george_davis@mentor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=v.narang@samsung.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®