mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: root <wang.yi59@zte.com.cn>
To: pmladek@suse.com
Cc: sergey.senozhatsky@gmail.com, rostedt@goodmis.org,
	linux-kernel@vger.kernel.org, xue.zhihong@zte.com.cn,
	wang.yi59@zte.com.cn, jiang.xuexin@zte.com.cn,
	汪勇10269566 <wang.yong12@zte.com.cn>
Subject: [PATCH] [PATCH]Fixed: line break of pr_cont not take effect in linux-rt
Date: Thu, 21 May 2020 09:37:44 +0800	[thread overview]
Message-ID: <1590025064-14433-1-git-send-email-wang.yi59@zte.com.cn> (raw)

From: 汪勇10269566 <wang.yong12@zte.com.cn>

Line break of pr_cont not take effect.
Use several pr_cont to print continuous paragraph, it is expected to
have line break when line ends up with  '\n', however the paragraph
does not have line break
-printk_kthread_func will not print info before log_store insert msg
 into printk_rb, and pr_cont calls cont_add to keep data in buffer.
 cont_add only when the following conditions are met insert msg to
 printk_rb
 1.cpu != c->cpu_owner || !(flags & LOG_CONT)
 2.c->len + len > sizeof(c->buf)

Signed-off-by: 汪勇10269566 <wang.yong12@zte.com.cn>
---
 kernel/printk/printk.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 0605a74..d898f50 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -1871,6 +1871,7 @@ static void cont_add(int ctx, int cpu, u32 caller_id, int facility, int level,
 	// but later continuations can add a newline.
 	if (flags & LOG_NEWLINE) {
 		c->flags |= LOG_NEWLINE;
+		cont_flush(ctx);
 	}
 }
 
-- 
2.15.2


             reply	other threads:[~2020-05-21  1:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-21  1:37 root [this message]
2020-05-22 10:15 ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1590025064-14433-1-git-send-email-wang.yi59@zte.com.cn \
    --to=wang.yi59@zte.com.cn \
    --cc=jiang.xuexin@zte.com.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=wang.yong12@zte.com.cn \
    --cc=xue.zhihong@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®