From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933283AbbGUQ0c (ORCPT ); Tue, 21 Jul 2015 12:26:32 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:62307 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754146AbbGUQ03 (ORCPT ); Tue, 21 Jul 2015 12:26:29 -0400 Date: Tue, 21 Jul 2015 18:25:42 +0200 (CEST) From: Stefan Wahren Reply-To: Stefan Wahren To: Srinivas Kandagatla , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org Cc: wxt@rock-chips.com, linux-api@vger.kernel.org, Rob Herring , sboyd@codeaurora.org, arnd@arndb.de, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, mporter@konsulko.com, linux-arm-msm@vger.kernel.org, Maxime Ripard , pantelis.antoniou@konsulko.com, Mark Brown , devicetree@vger.kernel.org Message-ID: <1590184041.70825.1437495942088.JavaMail.open-xchange@oxbsltgw08.schlund.de> In-Reply-To: <1437403403-4180-1-git-send-email-srinivas.kandagatla@linaro.org> References: <1437403352-4091-1-git-send-email-srinivas.kandagatla@linaro.org> <1437403403-4180-1-git-send-email-srinivas.kandagatla@linaro.org> Subject: Re: [PATCH v8 2/9] nvmem: Add a simple NVMEM framework for consumers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.6.2-Rev24 X-Originating-Client: com.openexchange.ox.gui.dhtml X-Provags-ID: V03:K0:0vAeHmrnRz/Nk6gxQKnudw0j1q3Egb/4H9gx6LEIWN0pWf0qa3D scJqFt3CC0iWnu45WQp3IXtBM3LYUiVAWPDMBuOKtsxNWjSOblo3NtclYh4jw+H/3CHOc2u GCo07e/fB0MWBE3efjYVYfQ9MCiDpiXrJbxRAs6GdH5zraoTiV3KMN4kpMefXlBvnnvWtK5 GdkLtbthIVmX4/+hatOYA== X-UI-Out-Filterresults: notjunk:1;V01:K0:M6NgKsTg62U=:qXeR+0X0rQzo4aWW77aJTF CtI+zK9c4fV3m3j8WDYqjE03+nM1Hog1se5tAVb3kVWf9aefGdrRkMCi3tW7oUo+Jm6kgQnfx qwOZvcZTr5+RTuz1EWx35gniMmvnYWHAUYSfeOl+m8pHjIizGEVqDjY5cILWXIvyqWNRoKPk4 IV5+XLnFmEibg/KiDzElYVYfSnE01ObV12Ql0/3dA+EbKu4QsETOwyhj5BkUinBTEO2djE1tN X6GTEope3xKsU9Ipg7B0RyRzyjHACqNnYxGBSn+McIgWrDyrGpsqwEB8NmxqmYg4Hr4GyInKs 4JWT8iLlrcSBGqY5lxsxiBJSbWPWzjc691LndjnDj77ObHClPP8/WLsQ+Mcv+4rlZ6AXB8Q5A 8EbQ5IPaO84j9uJiu7mKqIG9K9x4tXPvYbA+i4HCq2AlpuhLXUG5KSLN7LGrf0uLau5Lj3V4L 3oIXQe9wDprtYucIiH0KDsFaEPwesHAMAeQ+sH1qC/Db7ya2YLJS+LYmFHRZRJzAVPXhQ3bcC GSZi45zjutijgQbFuNSVK+mORg+bhv69jKl3JfkrTOkv3R5Lr1d9j8nozkk6WMAQQaLoV0ZPB j515uU7TgiNgS4NnUTx7m2CJUG96R9uWJMct86zo++siYHUFzOP/DfcTSYDTTvIYaQim/C4m5 37pChK4Cfr3evo+rckzlf89K2w7e3nnJhXKPnb/DnnCAnvA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Srinivas, > Srinivas Kandagatla hat am 20. Juli 2015 um > 16:43 geschrieben: > > > This patch adds just consumers part of the framework just to enable easy > review. > > Up until now, nvmem drivers were stored in drivers/misc, where they all > had to duplicate pretty much the same code to register a sysfs file, > allow in-kernel users to access the content of the devices they were > driving, etc. > > This was also a problem as far as other in-kernel users were involved, > since the solutions used were pretty much different from on driver to > another, there was a rather big abstraction leak. > > This introduction of this framework aims at solving this. It also > introduces DT representation for consumer devices to go get the data they > require (MAC Addresses, SoC/Revision ID, part numbers, and so on) from > the nvmems. > > Having regmap interface to this framework would give much better > abstraction for nvmems on different buses. > > Signed-off-by: Maxime Ripard > [Maxime Ripard: intial version of the framework] > Signed-off-by: Srinivas Kandagatla > --- > drivers/nvmem/core.c | 415 +++++++++++++++++++++++++++++++++++++++++ > include/linux/nvmem-consumer.h | 61 ++++++ > 2 files changed, 476 insertions(+) > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index bde5528..de14c36 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > [...] > +struct nvmem_cell *of_nvmem_cell_get(struct device_node *np, > + const char *name) > +{ > + struct device_node *cell_np, *nvmem_np; > + struct nvmem_cell *cell; > + struct nvmem_device *nvmem; > + const __be32 *addr; > + int rval, len, index; > + > + index = of_property_match_string(np, "nvmem-cell-names", name); > + > + cell_np = of_parse_phandle(np, "nvmem-cells", index); > + if (!cell_np) > + return ERR_PTR(-EINVAL); > + > + nvmem_np = of_get_next_parent(cell_np); > + if (!nvmem_np) > + return ERR_PTR(-EINVAL); > + > + nvmem = __nvmem_device_get(nvmem_np, NULL, NULL); > + if (IS_ERR(nvmem)) > + return ERR_CAST(nvmem); > + > + addr = of_get_property(cell_np, "reg", &len); > + if (!addr || (len < 2 * sizeof(int))) { I'm not sure, but shouldn't be sizeof(u32) more portable? > [...] > + > + addr = of_get_property(cell_np, "bits", &len); > + if (addr && len == (2 * sizeof(int))) { dito Regards Stefan