From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754049AbbBTLJx (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 Feb 2015 06:09:53 -0500
Received: from mout.kundenserver.de ([212.227.126.130]:51676 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753006AbbBTLJw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 Feb 2015 06:09:52 -0500
Date: Fri, 20 Feb 2015 12:09:44 +0100 (CET)
From: Stefan Wahren <stefan.wahren@i2se.com>
Reply-To: Stefan Wahren <stefan.wahren@i2se.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Sascha Hauer <kernel@pengutronix.de>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Shawn Guo <shawn.guo@linaro.org>,
        Mike Turquette <mturquette@linaro.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        Marek Vasut <marex@denx.de>, Zhi Li <lznuaa@gmail.com>
Message-ID: <1590447717.894708.1424430584776.JavaMail.open-xchange@oxbaltgw03.schlund.de>
In-Reply-To: <1705379122.406018.1423686677196.JavaMail.open-xchange@oxbaltgw01.schlund.de>
References: <1422645610-3052-1-git-send-email-stefan.wahren@i2se.com> <CAOMZO5DOgdUYsRUU3TXgJY+JhjF8xC_XY8EJFcrM7NHiPmSMOQ@mail.gmail.com> <54DA020C.6030703@i2se.com> <CAOMZO5DGCP1p1vetwWHpSbe2qywA8DhWRRq22egMDFSw11uq4w@mail.gmail.com> <54DA0DE7.5050708@i2se.com> <CAOMZO5AtFOThRjcAgMVbrbkcrJbehouSxoH03VUGJrRdWXnS_Q@mail.gmail.com> <462270270.419156.1423603473431.JavaMail.open-xchange@oxbaltgw02.schlund.de> <CAOMZO5B4mxP6RBkbsbj=wC6bZJgtreoo5S_NhYuki6kW=Y=QFw@mail.gmail.com> <1705379122.406018.1423686677196.JavaMail.open-xchange@oxbaltgw01.schlund.de>
Subject: Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac
 registers
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Medium
X-Mailer: Open-Xchange Mailer v7.6.0-Rev36
X-Originating-Client: com.openexchange.ox.gui.dhtml
X-Provags-ID: V03:K0:76HqkbOoV6Kd6AawEvmY2aGPTyXmwPOElxm9YcycxLVEWjjxZq+
 Am0GSitKhpQItzuplmMdlemmUJnO4ZP0tzemE75omAJUI+a/d/jNE7Z+0RxW1dGSQH7bACY
 cti6NYFrhJqaiCrBQvfaCL9JR4wc4KKXXQHpUnWQ8e2DbFGT9VETgAYPEjjOR3VrObjgnlQ
 gJCWxIt1EXpWYSxgKueIA==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Fabio,

> Stefan Wahren <stefan.wahren@i2se.com> hat am 11. Februar 2015 um 21:31
> geschrieben:
>
>
> Hi Fabio,
>
> > Fabio Estevam <festevam@gmail.com> hat am 11. Februar 2015 um 17:58
> > geschrieben:
> >
> >
> > Hi Stefan,
> >
> > On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren <stefan.wahren@i2se.com>
> > wrote:
> > > Hi Fabio,
> > >
> > >> Fabio Estevam <festevam@gmail.com> hat am 10. Februar 2015 um 16:06
> > >> geschrieben:
> > >>
> > >>
> > >> Hi Stefan,
> > >>
> > >> On Tue, Feb 10, 2015 at 11:55 AM, Stefan Wahren <stefan.wahren@i2se.com>
> > >> wrote:
> > >>
> > >> > Could you apply only the clk-imx28.c part of my patch and see what
> > >> > happens?
> > >>
> > >> If I apply only the clk-imx28.c part of your patch I can successfully
> > >> probe the SPI NOR.
> > >
> > > thanks this is very helpful. I built the linux-next for my Duckbill and
> > > add
> > > the
> > > SSP2 section from imx28-evk.dts into imx28-duckbill.dts.
> > >
> > > Without my patch i get the following for HW_CLKCTRL_FRAC0:
> > >
> > > ./memwatch -a 0x800401B0
> > >
> > > 0x800401b0: 0x5e5b5513
> > >
> > > With my patch i get:
> > >
> > > ./memwatch -a 0x800401B0
> > >
> > > 0x800401b0: 0x5e1b5513
> >
> > I always get 0x5e5b5513 with or without your patch.
>
> very strange. Do you have any idea why IO1_STABLE is permanent low?
>
> Here are the register dumps as requested by Mike.
>
> Without this patch after boot
>
> 0x80040000: 0x00060000
> 0x80040010: 0x800004b1
> 0x80040050: 0x00011001
> 0x80040080: 0x64000001
> 0x80040090: 0x00000001
> 0x800400a0: 0x80000001
> 0x800400b0: 0x00000002
> 0x800400c0: 0xa0000001
> 0x800401b0: 0x5e5b5513
> 0x800401c0: 0x00929292
> 0x800401d0: 0x00004104
>
> With this patch after boot
>
> 0x80040000: 0x00060000
> 0x80040010: 0x800004b1
> 0x80040050: 0x00011001
> 0x80040080: 0x64000001
> 0x80040090: 0x00000001
> 0x800400a0: 0x80000001
> 0x800400b0: 0x00000002
> 0x800400c0: 0xa0000001
> 0x800401b0: 0x5e1b5513
> 0x800401c0: 0x00929292
> 0x800401d0: 0x00004104

just for the records here is the register dump for the case "patch V2 on
Duckbill with U-Boot instead of imx-bootlets":

0x80040000: 0x00060000
0x80040010: 0x800004b1
0x80040050: 0x00011001
0x80040080: 0x64000001
0x80040090: 0x00000005
0x800400a0: 0x80000001
0x800400b0: 0x00000002
0x800400c0: 0xa0000001
0x800401b0: 0x5e5b5513
0x800401c0: 0x00929292
0x800401d0: 0x00004104

So the issue with IO1_STABLE seems to come from the bootloader.

Do you have any idea which i.MX28 registers additionally could be relevant?

Stefan