From: Sumit Garg <sumit.garg@linaro.org>
To: daniel.thompson@linaro.org
Cc: kgdb-bugreport@lists.sourceforge.net, jason.wessel@windriver.com,
dianders@chromium.org, pmladek@suse.com,
sergey.senozhatsky@gmail.com, gregkh@linuxfoundation.org,
jslaby@suse.com, linux-kernel@vger.kernel.org,
Sumit Garg <sumit.garg@linaro.org>
Subject: [PATCH v5 0/4] kdb: Improve console handling
Date: Wed, 3 Jun 2020 12:52:11 +0530 [thread overview]
Message-ID: <1591168935-6382-1-git-send-email-sumit.garg@linaro.org> (raw)
This patch-set is aimed to improve console handling especially when kdb
operates in NMI context.
Brief description of enhancements:
- Add status check for console prior to invoking corresponding handler.
- Fixup to avoid possible deadlock in NMI context due to usage of locks
in the console handlers.
- Prefer usage of polling I/O driver mode (lockless APIs) over invocation
of console handlers.
Changes in v5:
- Rebased on top of tags/kgdb-5.8-rc1.
- Get rid of kdb_io_write().
- Fixed issue reported by kbuild test robot.
- Remove is_console from kgdboc_earlycon_io_ops as well.
- Misc. comments.
- Added Doug's review tag.
Changes in v4:
- Use dbg_io_ops->write_char() directly instead of passing it as a
function pointer.
- Use "struct console" rather than "struct tty_driver" for comparison.
- Make commit descriptions and comments more informative.
- Add review tag for patch #2.
Changes in v3:
- Split patch to have separate patch for console status check.
- New patch to re-factor kdb message emit code.
- New patch to prefer polling I/O over console mode.
- Add code comments to describe usage of oops_in_progress.
Changes in v2:
- Use oops_in_progress directly instead of bust_spinlocks().
Sumit Garg (4):
kdb: Re-factor kdb_printf() message write code
kdb: Check status of console prior to invoking handlers
kdb: Make kdb_printf() console handling more robust
kdb: Switch to use safer dbg_io_ops over console APIs
drivers/tty/serial/kgdb_nmi.c | 2 +-
drivers/tty/serial/kgdboc.c | 6 ++--
drivers/usb/early/ehci-dbgp.c | 3 +-
include/linux/kgdb.h | 5 ++-
kernel/debug/kdb/kdb_io.c | 72 ++++++++++++++++++++++++++-----------------
5 files changed, 51 insertions(+), 37 deletions(-)
--
2.7.4
next reply other threads:[~2020-06-03 7:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 7:22 Sumit Garg [this message]
2020-06-03 7:22 ` [PATCH v5 1/4] kdb: Re-factor kdb_printf() message write code Sumit Garg
2020-06-03 8:07 ` Petr Mladek
2020-06-03 7:22 ` [PATCH v5 2/4] kdb: Check status of console prior to invoking handlers Sumit Garg
2020-06-03 8:08 ` Petr Mladek
2020-06-03 7:22 ` [PATCH v5 3/4] kdb: Make kdb_printf() console handling more robust Sumit Garg
2020-06-03 8:10 ` Petr Mladek
2020-06-03 7:22 ` [PATCH v5 4/4] kdb: Switch to use safer dbg_io_ops over console APIs Sumit Garg
2020-06-03 8:25 ` Petr Mladek
2020-06-03 9:18 ` Daniel Thompson
2020-06-03 11:59 ` Petr Mladek
2020-06-03 9:32 ` Sumit Garg
2020-06-03 11:42 ` Daniel Thompson
2020-06-03 13:05 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591168935-6382-1-git-send-email-sumit.garg@linaro.org \
--to=sumit.garg@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason.wessel@windriver.com \
--cc=jslaby@suse.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®