From: Paul Mackerras <paulus@samba.org>
To: davem@redhat.com
Cc: Patrick McHardy <kaber@trash.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: PPP_FILTER outbound only drops with debugging enables
Date: Sat, 18 Jan 2003 09:20:38 +1100 [thread overview]
Message-ID: <15912.33206.305816.56149@argo.ozlabs.ibm.com> (raw)
In-Reply-To: <3E27F79F.2090705@trash.net>
Dave,
This patch looks obviously correct, please send it on to Linus.
Paul.
Patrick McHardy writes:
> Hi.
>
> Packets in ppp_send_frame catched by pass_filter are only dropped if
> debuging is enabled:
[snip]
--- linux-2.4.20/drivers/net/ppp_generic.c.orig 2003-01-17 13:15:32.000000000 +0100
+++ linux-2.4.20/drivers/net/ppp_generic.c 2003-01-17 13:16:23.000000000 +0100
@@ -965,11 +965,10 @@
if (ppp->pass_filter.filter
&& sk_run_filter(skb, ppp->pass_filter.filter,
ppp->pass_filter.len) == 0) {
- if (ppp->debug & 1) {
+ if (ppp->debug & 1)
printk(KERN_DEBUG "PPP: outbound frame not passed\n");
- kfree_skb(skb);
- return;
- }
+ kfree_skb(skb);
+ return;
}
/* if this packet passes the active filter, record the time */
if (!(ppp->active_filter.filter
prev parent reply other threads:[~2003-01-17 22:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-17 12:31 Patrick McHardy
2003-01-17 22:20 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15912.33206.305816.56149@argo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=davem@redhat.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®