From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751965AbdJERcG (ORCPT ); Thu, 5 Oct 2017 13:32:06 -0400 Received: from esa1.dell-outbound.iphmx.com ([68.232.153.90]:19907 "EHLO esa1.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751744AbdJERcD (ORCPT ); Thu, 5 Oct 2017 13:32:03 -0400 From: X-LoopCount0: from 10.166.132.190 X-IronPort-AV: E=Sophos;i="5.42,481,1500958800"; d="scan'208";a="993953086" X-DLP: DLP_GlobalPCIDSS To: CC: , , , , , , , , , Subject: RE: [PATCH v4 05/14] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver Thread-Topic: [PATCH v4 05/14] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver Thread-Index: AQHTPWLwy4LaHQCqf0OMYSZFVl7S46LUxiSAgABIpQCAAByzgIAAGr2AgAADFsCAAFhXAP//tOMggAB/dgD//66uoA== Date: Thu, 5 Oct 2017 17:32:00 +0000 Message-ID: <15914f9166ad43b9af91f0fcf504ce80@ausx13mpc120.AMER.DELL.COM> References: <20171005010909.GC25018@fury> <20171005071153.GA31452@fury> <3be9670de8404523be04e2e319f1c1b3@ausx13mpc120.AMER.DELL.COM> <20171005141448.GB31452@fury> <5a114243f6844133a89d060347d5d390@ausx13mpc120.AMER.DELL.COM> <20171005172210.GC31452@fury> In-Reply-To: <20171005172210.GC31452@fury> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v95HWCfC011099 > -----Original Message----- > From: Darren Hart [mailto:dvhart@infradead.org] > Sent: Thursday, October 5, 2017 12:22 PM > To: Limonciello, Mario > Cc: andy.shevchenko@gmail.com; linux-kernel@vger.kernel.org; platform- > driver-x86@vger.kernel.org; luto@kernel.org; quasisec@google.com; > pali.rohar@gmail.com; rjw@rjwysocki.net; mjg59@google.com; hch@lst.de; > greg@kroah.com > Subject: Re: [PATCH v4 05/14] platform/x86: dell-wmi-descriptor: split WMI > descriptor into it's own driver > > On Thu, Oct 05, 2017 at 02:47:15PM +0000, Mario.Limonciello@dell.com wrote: > > > > > > > > So I believe it should be a mandatory runtime dependency due to needing > > > > the symbol dell_wmi_get_interface_version. Depmod should be handling > > > > this then no? > > > > > > This was nagging me all night, and I was thinking the last time I had to > > > use this it was indeed a runtime dependency. Sorry for the noise on > > > this. > > > > > > The kconfig needs to be setup such that dell-wmi-descriptor cannot be a > > > module if the dependent drivers are modules. > > > > > > -- > > > Darren Hart > > > VMware Open Source Technology Center > > > > Even if the others are modules shouldn't module ordering from depmod still > DTRT? > > You still won't be able to load dell-wmi.ko until dell-wmi-descriptor.ko was > loaded. > > > > I worded that wrong *facepalm*, let me try again... > > The kconfig needs to be setup such that dell-wmi-descriptor cannot be a > module if the dependent drivers are built-in. > OK got it. I've got Kconfig adjusted for this. Unlike DELL_SMBIOS, DELL_WMI_DESCRIPTOR could still be used on it's own.