mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Martin Josefsson <gandalf@wlug.westbo.se>
Cc: linux-kernel@vger.kernel.org
Subject: Re: problems with nfs-server in 2.5 bk as of 030115
Date: Mon, 20 Jan 2003 00:24:42 +0100	[thread overview]
Message-ID: <15915.13242.291976.585239@charged.uio.no> (raw)
In-Reply-To: <1043016608.727.0.camel@tux.rsn.bth.se>

>>>>> " " == Martin Josefsson <gandalf@wlug.westbo.se> writes:

     > On Sun, 2003-01-19 at 23:05, Trond Myklebust wrote:
    >> Could you apply the following patch, so that I can see what the
    >> actual returned error is?

     > RPC: Couldn't create pipefs entry /portmap/clnteb11b574, error
     > -17 RPC: Couldn't create pipefs entry /portmap/clnteb11b574,
     > error -17 RPC: Couldn't create pipefs entry
     > /portmap/clnteb11b574, error -17

OK. That's what I thought it might be...

Looks like rmdir() is failing, so that when 'clnt' gets reused, then
a directory with the old pathname still exists so mkdir() fails...

Could you try applying the following extra patch, just in order to
confirm that this is indeed the case (and to trace what the eventual
rmdir() error might be)?

Cheers,
  Trond

--- linux-2.5.59-00-fix/net/sunrpc/clnt.c.orig	2003-01-12 22:40:13.000000000 +0100
+++ linux-2.5.59-00-fix/net/sunrpc/clnt.c	2003-01-20 00:19:15.000000000 +0100
@@ -135,7 +135,12 @@
 	printk(KERN_INFO "RPC: out of memory in rpc_create_client\n");
 	goto out;
 out_no_auth:
-	rpc_rmdir(clnt->cl_pathname);
+	{
+		int error = rpc_rmdir(clnt->cl_pathname);
+		if (error)
+			printk(KERN_INFO "%s: rpc_rmdir(%s) failed with error %d\n",
+					__FUNCTION__, clnt->cl_pathname, error)
+	}
 out_no_path:
 	kfree(clnt);
 	clnt = NULL;
@@ -188,7 +193,12 @@
 		rpcauth_destroy(clnt->cl_auth);
 		clnt->cl_auth = NULL;
 	}
-	rpc_rmdir(clnt->cl_pathname);
+	{
+		int error = rpc_rmdir(clnt->cl_pathname);
+		if (error)
+			printk(KERN_INFO "%s: rpc_rmdir(%s) failed with error %d\n",
+					__FUNCTION__, clnt->cl_pathname, error)
+	}
 	if (clnt->cl_xprt) {
 		xprt_destroy(clnt->cl_xprt);
 		clnt->cl_xprt = NULL;

  parent reply	other threads:[~2003-01-19 23:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-19 21:39 Martin Josefsson
2003-01-19 22:05 ` Trond Myklebust
2003-01-19 22:50   ` Martin Josefsson
2003-01-19 23:22     ` Martin Josefsson
2003-01-19 23:24     ` Trond Myklebust [this message]
2003-01-20  0:17       ` Martin Josefsson
2003-01-20  1:00         ` Trond Myklebust
2003-01-20  1:17           ` Martin Josefsson
2003-01-20  1:20             ` Trond Myklebust
2003-01-20  1:26               ` Martin Josefsson
2003-01-20  1:34 ` Trond Myklebust
2003-01-20  1:50   ` Martin Josefsson
2003-01-20  2:01     ` Trond Myklebust
2003-01-20  2:17       ` Martin Josefsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15915.13242.291976.585239@charged.uio.no \
    --to=trond.myklebust@fys.uio.no \
    --cc=gandalf@wlug.westbo.se \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®